Settings: Users: Provide correct email in API

chrome/common/extensions/api/users_private.idl

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Use the <code>chrome.usersPrivate</code> API to manage users.
 [platforms=("chromeos"),
  implemented_in="chrome/browser/chromeos/extensions/users_private/users_private_api.h"]
 namespace usersPrivate {
 
   dictionary User {
     // Email for the user.
     DOMString email;
 
+    // Display email for the user.

[tommycli, 2017/05/17 15:56:12]

nit: Maybe "Displayed email" so it's not confused for a verb. Same with comment
on "Displayed name" too

[stevenjb, 2017/05/17 16:05:34]

Hmm, I feel like "display name" (and equivalent "display email") is the more
common usage (276 results for "display name" in chrome code vs. 8 for "displayed
name"; "display email" is less common but still twice as common as "displayed
email"), despite the potential for confusion (gotta love English). "Displayed"
has it's own problems (it hasn't actually been displayed anywhere yet), and "The
email address to use for display purposes" just sounds silly :)

[Devlin, 2017/05/17 16:16:14]

If we *really* wanted to bikeshed this, "emailForDisplay" or "nameForDisplay" is
probably most accurate.  But I agree with Steven that, in this case, consistency
is probably more useful.  Maybe we can keep the variables the same and just
update these comments, "Display-friendly email for the user" or something
similar?

+    DOMString displayEmail;
+
     // Display name for the user.
     DOMString name;
 
     // Whether this user is the device owner.
     boolean isOwner;
 
     // Whether this user is supervised.
     boolean isSupervised;
   };
 
@@ skipping 19 matching lines @@
     // the current user isn't the owner).
     static void removeWhitelistedUser(DOMString email, UserRemovedCallback callback);
 
     // Whether the current user is the owner of the device.
     static void isCurrentUserOwner(IsOwnerCallback callback);
 
     // Whether the whitelist is managed by enterprise.
     static void isWhitelistManaged(ManagedCallback callback);
   };
 };