Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1453)

Unified Diff: tools/perf/page_sets/system_health/system_health_story.py

Issue 2888133002: Modify list_system_health_stories to generate_system_health_csv (Closed)
Patch Set: Address Juan's nits Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/perf/page_sets/system_health/searching_stories.py ('k') | tools/perf/system_health_stories.csv » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/page_sets/system_health/system_health_story.py
diff --git a/tools/perf/page_sets/system_health/system_health_story.py b/tools/perf/page_sets/system_health/system_health_story.py
index aea6f800ea12f269597feaadbf78b913b41ea67f..62b6a6c3f44409c9f6af8d980ead54ccf230e649 100644
--- a/tools/perf/page_sets/system_health/system_health_story.py
+++ b/tools/perf/page_sets/system_health/system_health_story.py
@@ -87,6 +87,21 @@ class SystemHealthStory(page.Page):
self._take_memory_measurement = take_memory_measurement
@classmethod
+ def GetStoryDescription(cls):
+ if cls.__doc__:
+ return cls.__doc__
+ return cls.GenerateStoryDescription()
+
+ @classmethod
+ def GenerateStoryDescription(cls):
+ """ Subclasses of SystemHealthStory can override this to auto generate
+ their story description.
+ However, it's recommended to use the Python docstring to describe the user
+ stories instead and this should only be used for very repetitive cases.
+ """
+ return None
+
+ @classmethod
def CanRun(cls, possible_browser):
if (decorators.ShouldSkip(cls, possible_browser)[0] or
cls.ShouldDisable(possible_browser)):
« no previous file with comments | « tools/perf/page_sets/system_health/searching_stories.py ('k') | tools/perf/system_health_stories.csv » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698