Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Unified Diff: tools/perf/page_sets/system_health/background_stories.py

Issue 2888133002: Modify list_system_health_stories to generate_system_health_csv (Closed)
Patch Set: Address Juan's comments Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/perf/page_sets/system_health/background_stories.py
diff --git a/tools/perf/page_sets/system_health/background_stories.py b/tools/perf/page_sets/system_health/background_stories.py
index 59b4c132394bb92724a89d2f35dbdb8c8aea7e3e..4a385f17bfe49df04a121e5a68fc37774064f488 100644
--- a/tools/perf/page_sets/system_health/background_stories.py
+++ b/tools/perf/page_sets/system_health/background_stories.py
@@ -24,6 +24,10 @@ class _BackgroundStory(system_health_story.SystemHealthStory):
action_runner.tab.browser.Background()
super(_BackgroundStory, self)._Measure(action_runner)
+ @classmethod
+ def GenerateStoryDescription(cls):
+ return 'Load %s, then put the Chrome browser into the background.' % cls.URL
perezju 2017/05/19 13:48:29 nit: "put the Chrome browser" --> "put the browser
nednguyen 2017/05/19 15:07:50 Done.
+
class BackgroundGoogleStory(_BackgroundStory):
NAME = 'background:search:google'
@@ -43,7 +47,6 @@ class BackgroundFacebookMobileStory(_BackgroundStory):
class BackgroundNytimesMobileStory(_BackgroundStory):
- """The third top website in http://www.alexa.com/topsites/category/News"""
NAME = 'background:news:nytimes'
URL = 'http://www.nytimes.com/2016/10/04/us/politics/vice-presidential-debate.html?_r=0'
SUPPORTED_PLATFORMS = platforms.MOBILE_ONLY

Powered by Google App Engine
This is Rietveld 408576698