Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Side by Side Diff: tools/perf/page_sets/system_health/system_health_story.py

Issue 2888133002: Modify list_system_health_stories to generate_system_health_csv (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2016 The Chromium Authors. All rights reserved. 1 # Copyright 2016 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 from page_sets.system_health import platforms 5 from page_sets.system_health import platforms
6 from page_sets.system_health import story_tags 6 from page_sets.system_health import story_tags
7 7
8 from telemetry import decorators 8 from telemetry import decorators
9 from telemetry.page import page 9 from telemetry.page import page
10 from telemetry.page import shared_page_state 10 from telemetry.page import shared_page_state
(...skipping 69 matching lines...) Expand 10 before | Expand all | Expand 10 after
80 tags.append(t.name) 80 tags.append(t.name)
81 super(SystemHealthStory, self).__init__( 81 super(SystemHealthStory, self).__init__(
82 shared_page_state_class=_SystemHealthSharedState, page_set=story_set, 82 shared_page_state_class=_SystemHealthSharedState, page_set=story_set,
83 name=self.NAME, url=self.URL, tags=tags, 83 name=self.NAME, url=self.URL, tags=tags,
84 credentials_path='../data/credentials.json', 84 credentials_path='../data/credentials.json',
85 grouping_keys={'case': case, 'group': group}, 85 grouping_keys={'case': case, 'group': group},
86 platform_specific=self.PLATFORM_SPECIFIC) 86 platform_specific=self.PLATFORM_SPECIFIC)
87 self._take_memory_measurement = take_memory_measurement 87 self._take_memory_measurement = take_memory_measurement
88 88
89 @classmethod 89 @classmethod
90 def GetStoryDescription(cls):
91 if not cls.ABSTRACT_STORY and cls.__doc__:
92 return cls.__doc__
perezju 2017/05/18 09:52:35 maybe just return the first line (title) of the do
nednguyen 2017/05/18 14:02:58 For cases like https://cs.chromium.org/chromium/sr
perezju 2017/05/19 13:48:29 I think it's valuable to have a long full explanat
93 return 'N/A'
94
95 @classmethod
90 def CanRun(cls, possible_browser): 96 def CanRun(cls, possible_browser):
91 if (decorators.ShouldSkip(cls, possible_browser)[0] or 97 if (decorators.ShouldSkip(cls, possible_browser)[0] or
92 cls.ShouldDisable(possible_browser)): 98 cls.ShouldDisable(possible_browser)):
93 return False 99 return False
94 return True 100 return True
95 101
96 @classmethod 102 @classmethod
97 def ShouldDisable(cls, possible_browser): 103 def ShouldDisable(cls, possible_browser):
98 """Override this method to disable a story under specific conditions. 104 """Override this method to disable a story under specific conditions.
99 105
(...skipping 15 matching lines...) Expand all
115 pass 121 pass
116 122
117 def RunNavigateSteps(self, action_runner): 123 def RunNavigateSteps(self, action_runner):
118 self._Login(action_runner) 124 self._Login(action_runner)
119 super(SystemHealthStory, self).RunNavigateSteps(action_runner) 125 super(SystemHealthStory, self).RunNavigateSteps(action_runner)
120 126
121 def RunPageInteractions(self, action_runner): 127 def RunPageInteractions(self, action_runner):
122 action_runner.tab.WaitForDocumentReadyStateToBeComplete() 128 action_runner.tab.WaitForDocumentReadyStateToBeComplete()
123 self._DidLoadDocument(action_runner) 129 self._DidLoadDocument(action_runner)
124 self._Measure(action_runner) 130 self._Measure(action_runner)
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698