Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(434)

Unified Diff: components/signin/core/browser/signin_error_controller.cc

Issue 288813003: Add username of account that has an auth error. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address review comments Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/signin/core/browser/signin_error_controller.cc
diff --git a/components/signin/core/browser/signin_error_controller.cc b/components/signin/core/browser/signin_error_controller.cc
index 3d3060bc4c49425b9320b3f223abc20c56048252..eb680105d10cb8a2674404d1a71b543ac518a3aa 100644
--- a/components/signin/core/browser/signin_error_controller.cc
+++ b/components/signin/core/browser/signin_error_controller.cc
@@ -62,11 +62,13 @@ void SigninErrorController::AuthStatusChanged() {
}
std::string account_id = (*it)->GetAccountId();
+ std::string username = (*it)->GetUsername();
// Prioritize this error if it matches the previous |auth_error_|.
if (error.state() == prev_state && account_id == prev_account_id) {
auth_error_ = error;
error_account_id_ = account_id;
+ error_username_ = username;
error_changed = true;
break;
}
@@ -76,6 +78,7 @@ void SigninErrorController::AuthStatusChanged() {
if (!error_changed) {
auth_error_ = error;
error_account_id_ = account_id;
+ error_username_ = username;
error_changed = true;
}
}
@@ -84,6 +87,7 @@ void SigninErrorController::AuthStatusChanged() {
// No provider reported an error, so clear the error we have now.
auth_error_ = GoogleServiceAuthError::AuthErrorNone();
error_account_id_.clear();
+ error_username_.clear();
error_changed = true;
}

Powered by Google App Engine
This is Rietveld 408576698