Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 288813002: Don't throw "completed" exception (Closed)

Created:
6 years, 7 months ago by not at google - send to devlin
Modified:
6 years, 7 months ago
Reviewers:
Jeffrey Yasskin
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, aboxhall
Visibility:
Public.

Description

Don't throw a confusing "completed" exception at the end of extension tests. It's no longer needed (as try jobs indicate), possibly since r269230. R=jyasskin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270776

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M chrome/renderer/resources/extensions/test_custom_bindings.js View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
not at google - send to devlin
6 years, 7 months ago (2014-05-15 15:33:45 UTC) #1
Jeffrey Yasskin
lgtm
6 years, 7 months ago (2014-05-15 17:39:55 UTC) #2
not at google - send to devlin
The CQ bit was checked by kalman@chromium.org
6 years, 7 months ago (2014-05-15 18:16:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kalman@chromium.org/288813002/1
6 years, 7 months ago (2014-05-15 18:17:18 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-15 19:10:26 UTC) #5
commit-bot: I haz the power
6 years, 7 months ago (2014-05-15 19:34:36 UTC) #6
Message was sent while issue was closed.
Change committed as 270776

Powered by Google App Engine
This is Rietveld 408576698