Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6718)

Unified Diff: chrome/browser/resources/ntp4/md_incognito_tab.js

Issue 2888103002: Speed up the Incognito NTP reload (Closed)
Patch Set: Use the fontSize attribute directly. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/ntp4/md_incognito_tab.js
diff --git a/chrome/browser/resources/ntp4/md_incognito_tab.js b/chrome/browser/resources/ntp4/md_incognito_tab.js
index 3918f70126322fd2dc661c8f65c12be8a393ae16..a48c9a0d3ba991e267c72305f3272989c1ade41a 100644
--- a/chrome/browser/resources/ntp4/md_incognito_tab.js
+++ b/chrome/browser/resources/ntp4/md_incognito_tab.js
@@ -24,8 +24,17 @@ window.addEventListener('load', function() {
var bulletpoints = document.querySelectorAll('.bulletpoints');
var content = document.querySelector('.content');
- var maxWidth = (bulletpoints[0].offsetWidth + bulletpoints[1].offsetWidth +
- 40 /* margin */ + 2 /* offsetWidths may be rounded down */);
+ // Unless this is the first load of the Incognito NTP in this session and
+ // with this font size, we already have the maximum content width determined.
+ var fontSize = window.getComputedStyle(document.body).fontSize;
+ var maxWidth = localStorage[fontSize] ||
+ (bulletpoints[0].offsetWidth + bulletpoints[1].offsetWidth +
+ 40 /* margin */ + 2 /* offsetWidths may be rounded down */);
+
+ // Save the data for quicker access when the NTP is reloaded. Note that since
+ // we're in the Incognito mode, the local storage is ephemeral and the data
+ // will be discarded when the session ends.
+ localStorage[fontSize] = maxWidth;
// Limit the maximum width to 600px. That might force the two lists
// of bulletpoints under each other, in which case we must swap the left
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698