Remove raw DictionaryValue::Set in //chrome

chrome/common/extensions/command_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/extensions/command.h"
 
 #include <stddef.h>
 
 #include <memory>
+#include <utility>
 
 #include "base/macros.h"
+#include "base/memory/ptr_util.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/string_util.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/values.h"
 #include "build/build_config.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 class CommandTest : public testing::Test {
 };
 
@@ skipping 43 matching lines @@
     if (platform_specific_only &&
         std::find(platforms.begin(), platforms.end(), current_platform) ==
             platforms.end()) {
       // Given a |current_platform| without a |suggested_key|, |default| is
       // used. However, some keys, such as Search on Chrome OS, are only valid
       // for platform specific entries. Skip the test in this case.
       return;
     }
 
     input.reset(new base::DictionaryValue);
-    base::DictionaryValue* key_dict = new base::DictionaryValue();
+    auto key_dict = base::MakeUnique<base::DictionaryValue>();
 
     for (size_t j = 0; j < platforms.size(); ++j)
       key_dict->SetString(platforms[j], data.key);
 
-    input->Set("suggested_key", key_dict);
+    input->Set("suggested_key", std::move(key_dict));
     input->SetString("description", data.description);
 
     bool result = command.Parse(input.get(), data.command_name, i, &error);
     EXPECT_EQ(data.expected_result, result);
 
     if (result) {
       EXPECT_STREQ(data.description,
                    base::UTF16ToASCII(command.description()).c_str());
       EXPECT_STREQ(data.command_name, command.command_name().c_str());
       EXPECT_EQ(data.accelerator, command.accelerator());
@@ skipping 109 matching lines @@
     CheckParse(kTests[i], i, false, all_platforms);
 }
 
 TEST(CommandTest, ExtensionCommandParsingFallback) {
   std::string description = "desc";
   std::string command_name = "foo";
 
   // Test that platform specific keys are honored on each platform, despite
   // fallback being given.
   std::unique_ptr<base::DictionaryValue> input(new base::DictionaryValue);
-  base::DictionaryValue* key_dict = new base::DictionaryValue();
-  key_dict->SetString("default",  "Ctrl+Shift+D");
-  key_dict->SetString("windows",  "Ctrl+Shift+W");
-  key_dict->SetString("mac",      "Ctrl+Shift+M");
-  key_dict->SetString("linux",    "Ctrl+Shift+L");
+  input->SetString("description", description);
+  base::DictionaryValue* key_dict = input->SetDictionary(
+      "suggested_key", base::MakeUnique<base::DictionaryValue>());
+  key_dict->SetString("default", "Ctrl+Shift+D");
+  key_dict->SetString("windows", "Ctrl+Shift+W");
+  key_dict->SetString("mac", "Ctrl+Shift+M");
+  key_dict->SetString("linux", "Ctrl+Shift+L");
   key_dict->SetString("chromeos", "Ctrl+Shift+C");
-  input->Set("suggested_key", key_dict);
-  input->SetString("description", description);
 
   extensions::Command command;
   base::string16 error;
   EXPECT_TRUE(command.Parse(input.get(), command_name, 0, &error));
   EXPECT_STREQ(description.c_str(),
                base::UTF16ToASCII(command.description()).c_str());
   EXPECT_STREQ(command_name.c_str(), command.command_name().c_str());
 
 #if defined(OS_WIN)
   ui::Accelerator accelerator(ui::VKEY_W,
@@ skipping 78 matching lines @@
   };
   std::vector<std::string> non_chromeos;
   non_chromeos.push_back("default");
   non_chromeos.push_back("windows");
   non_chromeos.push_back("mac");
   non_chromeos.push_back("linux");
 
   for (size_t i = 0; i < arraysize(kNonChromeOsSearchTests); ++i)
     CheckParse(kNonChromeOsSearchTests[i], i, true, non_chromeos);
 }