Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Unified Diff: components/signin/core/browser/refresh_token_annotation_request.cc

Issue 2888053003: Network traffic annotation added to OAuth2ApiCallFlow and its subclasses. (Closed)
Patch Set: User authentication key added to data fields. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/signin/core/browser/refresh_token_annotation_request.cc
diff --git a/components/signin/core/browser/refresh_token_annotation_request.cc b/components/signin/core/browser/refresh_token_annotation_request.cc
index d1e11c92cacf651f931ec4217aeac545e7049b0c..d371cc7396bca8a1356f15f503db061fc0bbb7b3 100644
--- a/components/signin/core/browser/refresh_token_annotation_request.cc
+++ b/components/signin/core/browser/refresh_token_annotation_request.cc
@@ -17,6 +17,7 @@
#include "google_apis/gaia/gaia_constants.h"
#include "google_apis/gaia/gaia_urls.h"
#include "net/base/escape.h"
+#include "net/traffic_annotation/network_traffic_annotation.h"
#include "net/url_request/url_request_context_getter.h"
namespace {
@@ -171,3 +172,33 @@ void RefreshTokenAnnotationRequest::ProcessApiCallFailure(
base::ThreadTaskRunnerHandle::Get()->PostTask(FROM_HERE, request_callback_);
request_callback_.Reset();
}
+
+net::PartialNetworkTrafficAnnotationTag
+RefreshTokenAnnotationRequest::GetNetworkTrafficAnnotationTag() {
+ return net::DefinePartialNetworkTrafficAnnotation(
+ "refresh_token_annotation_request", "oauth2_api_call_flow", R"(
+ semantics {
+ sender: "Account Fetcher Service"
+ description:
+ "Sends request to /IssueToken endpoint with device_id to backfill "
msramek 2017/06/28 08:40:55 What is exactly is a device ID?
sacomoto 2017/06/30 10:09:54 I think this is a randomly generated ID scoped to
Ramin Halavati 2017/06/30 11:51:36 Done.
+ "device info for refresh tokens issued pre-M38."
+ trigger:
+ "When refreshing account information in AccountFetcherService. On "
+ "chrome startup and at most once per day."
+ data:
+ "Oauth2 access token for user, device_id for chrome profile, "
+ "chrome's client id, chrome version number."
+ destination: GOOGLE_OWNED_SERVICE
+ }
+ policy {
+ setting:
+ "This feature cannot be disabled by settings, however the request is "
+ "made only for signed-in users."
+ chrome_policy {
+ SigninAllowed {
+ policy_options {mode: MANDATORY}
+ SigninAllowed: false
+ }
+ }
+ })");
+}

Powered by Google App Engine
This is Rietveld 408576698