Network traffic annotation added to OAuth2ApiCallFlow and its subclasses.

google_apis/gaia/oauth2_api_call_flow.h

Index: google_apis/gaia/oauth2_api_call_flow.h
diff --git a/google_apis/gaia/oauth2_api_call_flow.h b/google_apis/gaia/oauth2_api_call_flow.h
index 846a907e1e5fc35f7401f1077b8233f8a04a1f19..1878e4ef262142dbf900629c3a426e96108d6548 100644
--- a/google_apis/gaia/oauth2_api_call_flow.h
+++ b/google_apis/gaia/oauth2_api_call_flow.h
@@ -9,6 +9,7 @@
 #include <string>
 
 #include "base/macros.h"
+#include "net/traffic_annotation/network_traffic_annotation.h"
 #include "net/url_request/url_fetcher.h"
 #include "net/url_request/url_fetcher_delegate.h"
 #include "url/gurl.h"
@@ -29,8 +30,10 @@ class OAuth2ApiCallFlow : public net::URLFetcherDelegate {
   ~OAuth2ApiCallFlow() override;
 
   // Start the flow.
-  virtual void Start(net::URLRequestContextGetter* context,
-                     const std::string& access_token);
+  virtual void Start(
+      net::URLRequestContextGetter* context,
+      const std::string& access_token,
+      const net::NetworkTrafficAnnotationTag& traffic_annotation);

[Roger Tawa OOO till Jul 10th, 2017/05/17 19:26:12]

Curious why adding an arg to Start() is better than declaring a new pure virtual
method like GetNetworkTrafficAnnotation() as we discussed earlier.  A pure
virtual method fits the pattern of how this class is configured for other
parameters like URL and body and such, and probably makes it easier to fix Tim's
comment about the various crypt calls.

[Ramin Halavati, 2017/05/24 13:04:41]

Done.

 
   // net::URLFetcherDelegate implementation.
   void OnURLFetchComplete(const net::URLFetcher* source) override;
@@ -69,7 +72,8 @@ class OAuth2ApiCallFlow : public net::URLFetcherDelegate {
   // The URLFether's method will be GET if body is empty, POST otherwise.
   std::unique_ptr<net::URLFetcher> CreateURLFetcher(
       net::URLRequestContextGetter* context,
-      const std::string& access_token);
+      const std::string& access_token,
+      const net::NetworkTrafficAnnotationTag& traffic_annotation);
 
   // Helper methods to implement the state machine for the flow.
   void BeginApiCall();