Network traffic annotation added to OAuth2ApiCallFlow and its subclasses.

components/cryptauth/cryptauth_api_call_flow.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/cryptauth/cryptauth_api_call_flow.h"
 
 #include "base/strings/string_number_conversions.h"
 #include "components/proximity_auth/logging/logging.h"
+#include "net/traffic_annotation/network_traffic_annotation.h"
 #include "net/url_request/url_fetcher.h"
 
 namespace cryptauth {
 
 namespace {
 
 const char kResponseBodyError[] = "Failed to get response body";
 const char kRequestFailedError[] = "Request failed";
 const char kHttpStatusErrorPrefix[] = "HTTP status: ";
 
 }  // namespace
 
 CryptAuthApiCallFlow::CryptAuthApiCallFlow() {
 }
 
 CryptAuthApiCallFlow::~CryptAuthApiCallFlow() {
 }
 
 void CryptAuthApiCallFlow::Start(const GURL& request_url,
                                  net::URLRequestContextGetter* context,
                                  const std::string& access_token,
                                  const std::string& serialized_request,
                                  const ResultCallback& result_callback,
                                  const ErrorCallback& error_callback) {
   request_url_ = request_url;
   serialized_request_ = serialized_request;
   result_callback_ = result_callback;
   error_callback_ = error_callback;
-  OAuth2ApiCallFlow::Start(context, access_token);
+  net::NetworkTrafficAnnotationTag traffic_annotation =
+      net::DefineNetworkTrafficAnnotation("...", R"(
+        semantics {
+          sender: "..."
+          description: "..."

[Tim Song, 2017/05/17 19:10:37]

This class is a generic wrapper for all API calls we make to the CryptAuth
service, so it encompasses a number of use cases. We would need to annotate each
instantiation of this class (or provide some enums) in order to properly
describe what each call is doing.

[Ramin Halavati, 2017/05/24 13:04:41]

Done.

+          trigger: "..."
+          data: "..."
+          destination: WEBSITE/GOOGLE_OWNED_SERVICE/OTHER/LOCAL
+        }
+        policy {
+          cookies_allowed: false/true
+          cookies_store: "..."
+          setting: "..."
+          chrome_policy {
+            [POLICY_NAME] {
+              policy_options {mode: MANDATORY/RECOMMENDED/UNSET}
+              [POLICY_NAME]: ... //(value to disable it)
+            }
+          }
+          policy_exception_justification: "..."
+        })");
+  OAuth2ApiCallFlow::Start(context, access_token, traffic_annotation);
 }
 
 GURL CryptAuthApiCallFlow::CreateApiCallUrl() {
   return request_url_;
 }
 
 std::string CryptAuthApiCallFlow::CreateApiCallBody() {
   return serialized_request_;
 }
 
@@ skipping 26 matching lines @@
     error_message = kRequestFailedError;
   }
 
   std::string response;
   source->GetResponseAsString(&response);
   PA_LOG(INFO) << "API call failed:\n" << response;
   error_callback_.Run(error_message);
 }
 
 }  // namespace cryptauth