Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(878)

Unified Diff: mojo/edk/system/node_controller.cc

Issue 2888053002: Rename TaskRunner::RunsTasksOnCurrentThread() in //extensions, //headless, //mojo (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/edk/system/node_controller.cc
diff --git a/mojo/edk/system/node_controller.cc b/mojo/edk/system/node_controller.cc
index 0901022a79cad29a7dbf0d7993c5292ec5bc8a54..4576720da16dd2d97853d10bede2de5d149142cc 100644
--- a/mojo/edk/system/node_controller.cc
+++ b/mojo/edk/system/node_controller.cc
@@ -106,7 +106,7 @@ class ThreadDestructionObserver :
public:
static void Create(scoped_refptr<base::TaskRunner> task_runner,
const base::Closure& callback) {
- if (task_runner->RunsTasksOnCurrentThread()) {
+ if (task_runner->RunsTasksInCurrentSequence()) {
// Owns itself.
new ThreadDestructionObserver(callback);
} else {
@@ -342,7 +342,7 @@ void NodeController::SendBrokerClientInvitationOnIOThread(
ConnectionParams connection_params,
ports::NodeName temporary_node_name,
const ProcessErrorCallback& process_error_callback) {
- DCHECK(io_task_runner_->RunsTasksOnCurrentThread());
+ DCHECK(io_task_runner_->RunsTasksInCurrentSequence());
#if !defined(OS_MACOSX) && !defined(OS_NACL)
PlatformChannelPair node_channel;
@@ -392,7 +392,7 @@ void NodeController::SendBrokerClientInvitationOnIOThread(
void NodeController::AcceptBrokerClientInvitationOnIOThread(
ConnectionParams connection_params) {
- DCHECK(io_task_runner_->RunsTasksOnCurrentThread());
+ DCHECK(io_task_runner_->RunsTasksInCurrentSequence());
{
base::AutoLock lock(parent_lock_);
@@ -418,7 +418,7 @@ void NodeController::ConnectToPeerOnIOThread(ConnectionParams connection_params,
ports::NodeName token,
ports::PortRef port,
const std::string& peer_token) {
- DCHECK(io_task_runner_->RunsTasksOnCurrentThread());
+ DCHECK(io_task_runner_->RunsTasksInCurrentSequence());
scoped_refptr<NodeChannel> channel = NodeChannel::Create(
this, std::move(connection_params), io_task_runner_, {});
@@ -478,7 +478,7 @@ scoped_refptr<NodeChannel> NodeController::GetBrokerChannel() {
void NodeController::AddPeer(const ports::NodeName& name,
scoped_refptr<NodeChannel> channel,
bool start_channel) {
- DCHECK(io_task_runner_->RunsTasksOnCurrentThread());
+ DCHECK(io_task_runner_->RunsTasksInCurrentSequence());
DCHECK(name != ports::kInvalidNodeName);
DCHECK(channel);
@@ -522,7 +522,7 @@ void NodeController::AddPeer(const ports::NodeName& name,
void NodeController::DropPeer(const ports::NodeName& name,
NodeChannel* channel) {
- DCHECK(io_task_runner_->RunsTasksOnCurrentThread());
+ DCHECK(io_task_runner_->RunsTasksInCurrentSequence());
{
base::AutoLock lock(peers_lock_);
@@ -719,7 +719,7 @@ void NodeController::ProcessIncomingMessages() {
}
void NodeController::DropAllPeers() {
- DCHECK(io_task_runner_->RunsTasksOnCurrentThread());
+ DCHECK(io_task_runner_->RunsTasksInCurrentSequence());
std::vector<scoped_refptr<NodeChannel>> all_peers;
{
@@ -832,7 +832,7 @@ void NodeController::PortStatusChanged(const ports::PortRef& port) {
void NodeController::OnAcceptChild(const ports::NodeName& from_node,
const ports::NodeName& parent_name,
const ports::NodeName& token) {
- DCHECK(io_task_runner_->RunsTasksOnCurrentThread());
+ DCHECK(io_task_runner_->RunsTasksInCurrentSequence());
scoped_refptr<NodeChannel> parent;
{
@@ -862,7 +862,7 @@ void NodeController::OnAcceptChild(const ports::NodeName& from_node,
void NodeController::OnAcceptParent(const ports::NodeName& from_node,
const ports::NodeName& token,
const ports::NodeName& child_name) {
- DCHECK(io_task_runner_->RunsTasksOnCurrentThread());
+ DCHECK(io_task_runner_->RunsTasksInCurrentSequence());
auto it = pending_invitations_.find(from_node);
if (it == pending_invitations_.end() || token != from_node) {
@@ -1067,7 +1067,7 @@ void NodeController::OnAcceptBrokerClient(const ports::NodeName& from_node,
void NodeController::OnPortsMessage(const ports::NodeName& from_node,
Channel::MessagePtr channel_message) {
- DCHECK(io_task_runner_->RunsTasksOnCurrentThread());
+ DCHECK(io_task_runner_->RunsTasksInCurrentSequence());
void* data;
size_t num_data_bytes, num_header_bytes, num_payload_bytes, num_ports_bytes;
@@ -1093,7 +1093,7 @@ void NodeController::OnRequestPortMerge(
const ports::NodeName& from_node,
const ports::PortName& connector_port_name,
const std::string& name) {
- DCHECK(io_task_runner_->RunsTasksOnCurrentThread());
+ DCHECK(io_task_runner_->RunsTasksInCurrentSequence());
DVLOG(2) << "Node " << name_ << " received RequestPortMerge for name " << name
<< " and port " << connector_port_name << "@" << from_node;
@@ -1130,7 +1130,7 @@ void NodeController::OnRequestPortMerge(
void NodeController::OnRequestIntroduction(const ports::NodeName& from_node,
const ports::NodeName& name) {
- DCHECK(io_task_runner_->RunsTasksOnCurrentThread());
+ DCHECK(io_task_runner_->RunsTasksInCurrentSequence());
scoped_refptr<NodeChannel> requestor = GetPeerChannel(from_node);
if (from_node == name || name == ports::kInvalidNodeName || !requestor) {
@@ -1154,7 +1154,7 @@ void NodeController::OnRequestIntroduction(const ports::NodeName& from_node,
void NodeController::OnIntroduce(const ports::NodeName& from_node,
const ports::NodeName& name,
ScopedPlatformHandle channel_handle) {
- DCHECK(io_task_runner_->RunsTasksOnCurrentThread());
+ DCHECK(io_task_runner_->RunsTasksInCurrentSequence());
if (!channel_handle.is_valid()) {
node_->LostConnectionToNode(name);
@@ -1209,7 +1209,7 @@ void NodeController::OnRelayPortsMessage(const ports::NodeName& from_node,
base::ProcessHandle from_process,
const ports::NodeName& destination,
Channel::MessagePtr message) {
- DCHECK(io_task_runner_->RunsTasksOnCurrentThread());
+ DCHECK(io_task_runner_->RunsTasksInCurrentSequence());
if (GetBrokerChannel()) {
// Only the broker should be asked to relay a message.
@@ -1287,7 +1287,7 @@ void NodeController::OnAcceptPeer(const ports::NodeName& from_node,
const ports::NodeName& token,
const ports::NodeName& peer_name,
const ports::PortName& port_name) {
- DCHECK(io_task_runner_->RunsTasksOnCurrentThread());
+ DCHECK(io_task_runner_->RunsTasksInCurrentSequence());
auto it = peer_connections_.find(from_node);
if (it == peer_connections_.end()) {
@@ -1325,7 +1325,7 @@ void NodeController::OnAcceptPeer(const ports::NodeName& from_node,
void NodeController::OnChannelError(const ports::NodeName& from_node,
NodeChannel* channel) {
- if (io_task_runner_->RunsTasksOnCurrentThread()) {
+ if (io_task_runner_->RunsTasksInCurrentSequence()) {
DropPeer(from_node, channel);
// DropPeer may have caused local port closures, so be sure to process any
// pending local messages.

Powered by Google App Engine
This is Rietveld 408576698