Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Unified Diff: extensions/browser/sandboxed_unpacker.cc

Issue 2888053002: Rename TaskRunner::RunsTasksOnCurrentThread() in //extensions, //headless, //mojo (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/sandboxed_unpacker.cc
diff --git a/extensions/browser/sandboxed_unpacker.cc b/extensions/browser/sandboxed_unpacker.cc
index 730ac6b1d018f55ad7c3c14ddb7da59d72499427..baba875fc1a4e610f8297cf1d1f45a953cafcd22 100644
--- a/extensions/browser/sandboxed_unpacker.cc
+++ b/extensions/browser/sandboxed_unpacker.cc
@@ -233,7 +233,7 @@ SandboxedUnpacker::SandboxedUnpacker(
}
bool SandboxedUnpacker::CreateTempDirectory() {
- CHECK(unpacker_io_task_runner_->RunsTasksOnCurrentThread());
+ CHECK(unpacker_io_task_runner_->RunsTasksInCurrentSequence());
base::FilePath temp_dir;
if (!FindWritableTempLocation(extensions_dir_, &temp_dir)) {
@@ -258,7 +258,7 @@ bool SandboxedUnpacker::CreateTempDirectory() {
void SandboxedUnpacker::StartWithCrx(const CRXFileInfo& crx_info) {
// We assume that we are started on the thread that the client wants us
// to do file IO on.
- CHECK(unpacker_io_task_runner_->RunsTasksOnCurrentThread());
+ CHECK(unpacker_io_task_runner_->RunsTasksInCurrentSequence());
crx_unpack_start_time_ = base::TimeTicks::Now();
std::string expected_hash;
@@ -445,7 +445,7 @@ void SandboxedUnpacker::UnpackDone(
void SandboxedUnpacker::UnpackExtensionSucceeded(
std::unique_ptr<base::DictionaryValue> manifest) {
- CHECK(unpacker_io_task_runner_->RunsTasksOnCurrentThread());
+ CHECK(unpacker_io_task_runner_->RunsTasksInCurrentSequence());
std::unique_ptr<base::DictionaryValue> final_manifest(
RewriteManifestFile(*manifest));
@@ -492,7 +492,7 @@ void SandboxedUnpacker::UnpackExtensionSucceeded(
}
void SandboxedUnpacker::UnpackExtensionFailed(const base::string16& error) {
- CHECK(unpacker_io_task_runner_->RunsTasksOnCurrentThread());
+ CHECK(unpacker_io_task_runner_->RunsTasksInCurrentSequence());
ReportFailure(
UNPACKER_CLIENT_FAILED,
@@ -903,7 +903,7 @@ bool SandboxedUnpacker::RewriteCatalogFiles() {
}
void SandboxedUnpacker::Cleanup() {
- DCHECK(unpacker_io_task_runner_->RunsTasksOnCurrentThread());
+ DCHECK(unpacker_io_task_runner_->RunsTasksInCurrentSequence());
if (!temp_dir_.Delete()) {
LOG(WARNING) << "Can not delete temp directory at "
<< temp_dir_.GetPath().value();

Powered by Google App Engine
This is Rietveld 408576698