Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1390)

Unified Diff: content/browser/renderer_host/render_widget_host_view_aura_unittest.cc

Issue 2888043004: [cc] Add and plumb CFS::DidNotProduceFrame. (Closed)
Patch Set: remove ExternalBFS::OnDidFinishFrame and related ack tracking. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_widget_host_view_aura_unittest.cc
diff --git a/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc b/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc
index 3694c7968fe6c78e9840593a7210d5a710739db2..954d34714d648ca4a87044a0f7fa79ae796d228b 100644
--- a/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc
+++ b/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc
@@ -3074,7 +3074,7 @@ class LastObserverTracker : public cc::FakeExternalBeginFrameSource::Client {
} // namespace
// Tests that BeginFrameAcks are forwarded correctly from the
-// SwapCompositorFrame and OnBeginFrameDidNotSwap IPCs through
+// SwapCompositorFrame and OnBeginFrameDidNotProduceFrame IPCs through
// DelegatedFrameHost and its CompositorFrameSinkSupport.
TEST_F(RenderWidgetHostViewAuraTest, ForwardsBeginFrameAcks) {
gfx::Rect view_rect(100, 100);
@@ -3122,9 +3122,9 @@ TEST_F(RenderWidgetHostViewAuraTest, ForwardsBeginFrameAcks) {
cc::CreateBeginFrameArgsForTesting(BEGINFRAME_FROM_HERE, source_id, 6u);
source.TestOnBeginFrame(args);
- // Explicit ack through OnBeginFrameDidNotSwap is forwarded.
+ // Explicit ack through OnBeginFrameDidNotProduceFrame is forwarded.
cc::BeginFrameAck ack(source_id, 6, 4, false);
- view_->OnBeginFrameDidNotSwap(ack);
+ view_->OnBeginFrameDidNotProduceFrame(ack);
EXPECT_EQ(ack, source.LastAckForObserver(observer_tracker.last_observer_));
}
@@ -3181,10 +3181,10 @@ TEST_F(RenderWidgetHostViewAuraTest, ForwardsBeginFrameAcks) {
BEGINFRAME_FROM_HERE, source_id, 11u);
source.TestOnBeginFrame(args);
- // Explicit ack through OnBeginFrameDidNotSwap is forwarded with invalid
- // latest_confirmed_sequence_number.
+ // Explicit ack through OnBeginFrameDidNotProduceFrame is forwarded with
+ // invalid latest_confirmed_sequence_number.
cc::BeginFrameAck ack(source_id, 11, 11, false);
- view_->OnBeginFrameDidNotSwap(ack);
+ view_->OnBeginFrameDidNotProduceFrame(ack);
ack.latest_confirmed_sequence_number =
cc::BeginFrameArgs::kInvalidFrameNumber;
EXPECT_EQ(ack, source.LastAckForObserver(observer_tracker.last_observer_));
@@ -3212,9 +3212,9 @@ TEST_F(RenderWidgetHostViewAuraTest, ForwardsBeginFrameAcks) {
BEGINFRAME_FROM_HERE, source_id, 13u);
source.TestOnBeginFrame(args);
- // Explicit ack through OnBeginFrameDidNotSwap is forwarded.
+ // Explicit ack through OnBeginFrameDidNotProduceFrame is forwarded.
cc::BeginFrameAck ack(source_id, 13, 13, false);
- view_->OnBeginFrameDidNotSwap(ack);
+ view_->OnBeginFrameDidNotProduceFrame(ack);
EXPECT_EQ(ack, source.LastAckForObserver(observer_tracker.last_observer_));
}

Powered by Google App Engine
This is Rietveld 408576698