Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Unified Diff: content/browser/frame_host/render_widget_host_view_child_frame_unittest.cc

Issue 2888043004: [cc] Add and plumb CFS::DidNotProduceFrame. (Closed)
Patch Set: remove ExternalBFS::OnDidFinishFrame and related ack tracking. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/render_widget_host_view_child_frame_unittest.cc
diff --git a/content/browser/frame_host/render_widget_host_view_child_frame_unittest.cc b/content/browser/frame_host/render_widget_host_view_child_frame_unittest.cc
index 1867a2903b2c34bc7c26cc322ff459c03c6a9c23..8d32c5fc2a5b0659a315424211f9689e7035aedb 100644
--- a/content/browser/frame_host/render_widget_host_view_child_frame_unittest.cc
+++ b/content/browser/frame_host/render_widget_host_view_child_frame_unittest.cc
@@ -245,7 +245,7 @@ TEST_F(RenderWidgetHostViewChildFrameTest, FrameEviction) {
}
// Tests that BeginFrameAcks are forwarded correctly from the
-// SwapCompositorFrame and OnBeginFrameDidNotSwap IPCs through the
+// SwapCompositorFrame and OnBeginFrameDidNotProduceFrame IPCs through the
// CompositorFrameSinkSupport.
TEST_F(RenderWidgetHostViewChildFrameTest, ForwardsBeginFrameAcks) {
gfx::Size view_size(100, 100);
@@ -280,9 +280,9 @@ TEST_F(RenderWidgetHostViewChildFrameTest, ForwardsBeginFrameAcks) {
cc::CreateBeginFrameArgsForTesting(BEGINFRAME_FROM_HERE, source_id, 6u);
source.TestOnBeginFrame(args);
- // Explicit ack through OnBeginFrameDidNotSwap is forwarded.
+ // Explicit ack through OnBeginFrameDidNotProduceFrame is forwarded.
cc::BeginFrameAck ack(source_id, 6, 4, false);
- view_->OnBeginFrameDidNotSwap(ack);
+ view_->OnBeginFrameDidNotProduceFrame(ack);
EXPECT_EQ(ack, source.LastAckForObserver(view_->support_.get()));
}

Powered by Google App Engine
This is Rietveld 408576698