Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2992)

Unified Diff: cc/test/test_compositor_frame_sink.cc

Issue 2888043004: [cc] Add and plumb CFS::DidNotProduceFrame. (Closed)
Patch Set: remove ExternalBFS::OnDidFinishFrame and related ack tracking. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/test/test_compositor_frame_sink.cc
diff --git a/cc/test/test_compositor_frame_sink.cc b/cc/test/test_compositor_frame_sink.cc
index f9d4f46e6c491ef7a7f0396ca6659e97c681a565..a04d1d8080da4db044259615581c2ba29bdbd1b6 100644
--- a/cc/test/test_compositor_frame_sink.cc
+++ b/cc/test/test_compositor_frame_sink.cc
@@ -127,6 +127,9 @@ void TestCompositorFrameSink::SetLocalSurfaceId(
}
void TestCompositorFrameSink::SubmitCompositorFrame(CompositorFrame frame) {
+ DCHECK(frame.metadata.begin_frame_ack.has_damage);
+ DCHECK_LE(BeginFrameArgs::kStartingFrameNumber,
+ frame.metadata.begin_frame_ack.sequence_number);
test_client_->DisplayReceivedCompositorFrame(frame);
if (!delegated_local_surface_id_.is_valid()) {
@@ -157,6 +160,13 @@ void TestCompositorFrameSink::SubmitCompositorFrame(CompositorFrame frame) {
}
}
+void TestCompositorFrameSink::BeginFrameDidNotProduceFrame(
+ const BeginFrameAck& ack) {
+ DCHECK(!ack.has_damage);
+ DCHECK_LE(BeginFrameArgs::kStartingFrameNumber, ack.sequence_number);
+ support_->BeginFrameDidNotProduceFrame(ack);
+}
+
void TestCompositorFrameSink::DidReceiveCompositorFrameAck(
const ReturnedResourceArray& resources) {
ReclaimResources(resources);
@@ -198,8 +208,6 @@ void TestCompositorFrameSink::OnNeedsBeginFrames(bool needs_begin_frames) {
support_->SetNeedsBeginFrame(needs_begin_frames);
}
-void TestCompositorFrameSink::OnDidFinishFrame(const BeginFrameAck& ack) {}
-
void TestCompositorFrameSink::SendCompositorFrameAckToClient() {
client_->DidReceiveCompositorFrameAck();
}

Powered by Google App Engine
This is Rietveld 408576698