services/ui/public/cpp/client_compositor_frame_sink.h - Issue 2888043004: [cc] Add and plumb CFS::DidNotProduceFrame.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: services/ui/public/cpp/client_compositor_frame_sink.h

Issue 2888043004: [cc] Add and plumb CFS::DidNotProduceFrame. (Closed)

Patch Set: address nits, rename to DidNotProduceFrame. Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: services/ui/public/cpp/client_compositor_frame_sink.h

diff --git a/services/ui/public/cpp/client_compositor_frame_sink.h b/services/ui/public/cpp/client_compositor_frame_sink.h

index 889cfa46697fc8410f43589a31fb2f785b570f2a..d21fe0f5ee55394b56fbfa3716298925ed3e6646 100644

--- a/services/ui/public/cpp/client_compositor_frame_sink.h

+++ b/services/ui/public/cpp/client_compositor_frame_sink.h

@@ -38,6 +38,7 @@ class ClientCompositorFrameSink

void DetachFromClient() override;

void SetLocalSurfaceId(const cc::LocalSurfaceId& local_surface_id) override;

void SubmitCompositorFrame(cc::CompositorFrame frame) override;

+ void DidNotProduceFrame(const cc::BeginFrameAck& ack) override;

private:

ClientCompositorFrameSink(

@@ -55,7 +56,6 @@ class ClientCompositorFrameSink

// cc::ExternalBeginFrameSourceClient implementation.

void OnNeedsBeginFrames(bool needs_begin_frames) override;

- void OnDidFinishFrame(const cc::BeginFrameAck& ack) override;

gfx::Size last_submitted_frame_size_;

cc::LocalSurfaceId local_surface_id_;