components/viz/frame_sinks/gpu_root_compositor_frame_sink.cc - Issue 2888043004: [cc] Add and plumb CFS::DidNotProduceFrame.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/viz/frame_sinks/gpu_root_compositor_frame_sink.cc

Issue 2888043004: [cc] Add and plumb CFS::DidNotProduceFrame. (Closed)

Patch Set: address nits, rename to DidNotProduceFrame. Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/viz/frame_sinks/gpu_root_compositor_frame_sink.cc

diff --git a/components/viz/frame_sinks/gpu_root_compositor_frame_sink.cc b/components/viz/frame_sinks/gpu_root_compositor_frame_sink.cc

index b614fe8811b7dff661545abf62c54a390754023e..850b6c7bbc74b0e5714427640d8dc937a73654b2 100644

--- a/components/viz/frame_sinks/gpu_root_compositor_frame_sink.cc

+++ b/components/viz/frame_sinks/gpu_root_compositor_frame_sink.cc

@@ -89,9 +89,9 @@ void GpuRootCompositorFrameSink::SubmitCompositorFrame(

support_->SubmitCompositorFrame(local_surface_id, std::move(frame));

}

-void GpuRootCompositorFrameSink::BeginFrameDidNotSwap(

+void GpuRootCompositorFrameSink::DidNotProduceFrame(

const cc::BeginFrameAck& begin_frame_ack) {

- support_->BeginFrameDidNotSwap(begin_frame_ack);

+ support_->DidNotProduceFrame(begin_frame_ack);

}

void GpuRootCompositorFrameSink::ClaimTemporaryReference(