Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Side by Side Diff: content/renderer/gpu/renderer_compositor_frame_sink.cc

Issue 2888043004: [cc] Add and plumb CFS::DidNotProduceFrame. (Closed)
Patch Set: remove ExternalBFS::OnDidFinishFrame and related ack tracking. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/renderer/gpu/renderer_compositor_frame_sink.h" 5 #include "content/renderer/gpu/renderer_compositor_frame_sink.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/command_line.h" 9 #include "base/command_line.h"
10 #include "base/location.h" 10 #include "base/location.h"
(...skipping 105 matching lines...) Expand 10 before | Expand all | Expand 10 after
116 compositor_frame_sink_filter_->RemoveHandlerOnCompositorThread( 116 compositor_frame_sink_filter_->RemoveHandlerOnCompositorThread(
117 routing_id_, compositor_frame_sink_filter_handler_); 117 routing_id_, compositor_frame_sink_filter_handler_);
118 sink_.reset(); 118 sink_.reset();
119 sink_client_binding_.Close(); 119 sink_client_binding_.Close();
120 cc::CompositorFrameSink::DetachFromClient(); 120 cc::CompositorFrameSink::DetachFromClient();
121 } 121 }
122 122
123 void RendererCompositorFrameSink::SubmitCompositorFrame( 123 void RendererCompositorFrameSink::SubmitCompositorFrame(
124 cc::CompositorFrame frame) { 124 cc::CompositorFrame frame) {
125 // We should only submit CompositorFrames with valid BeginFrameAcks. 125 // We should only submit CompositorFrames with valid BeginFrameAcks.
126 DCHECK(frame.metadata.begin_frame_ack.has_damage);
126 DCHECK_LE(cc::BeginFrameArgs::kStartingFrameNumber, 127 DCHECK_LE(cc::BeginFrameArgs::kStartingFrameNumber,
127 frame.metadata.begin_frame_ack.sequence_number); 128 frame.metadata.begin_frame_ack.sequence_number);
128 if (ShouldAllocateNewLocalSurfaceId(frame)) 129 if (ShouldAllocateNewLocalSurfaceId(frame))
129 local_surface_id_ = id_allocator_.GenerateId(); 130 local_surface_id_ = id_allocator_.GenerateId();
130 UpdateFrameData(frame); 131 UpdateFrameData(frame);
131 132
132 { 133 {
133 std::unique_ptr<FrameSwapMessageQueue::SendMessageScope> 134 std::unique_ptr<FrameSwapMessageQueue::SendMessageScope>
134 send_message_scope = 135 send_message_scope =
135 frame_swap_message_queue_->AcquireSendMessageScope(); 136 frame_swap_message_queue_->AcquireSendMessageScope();
136 std::vector<std::unique_ptr<IPC::Message>> messages; 137 std::vector<std::unique_ptr<IPC::Message>> messages;
137 frame_swap_message_queue_->DrainMessages(&messages); 138 frame_swap_message_queue_->DrainMessages(&messages);
138 std::vector<IPC::Message> messages_to_send; 139 std::vector<IPC::Message> messages_to_send;
139 FrameSwapMessageQueue::TransferMessages(&messages, &messages_to_send); 140 FrameSwapMessageQueue::TransferMessages(&messages, &messages_to_send);
140 uint32_t frame_token = 0; 141 uint32_t frame_token = 0;
141 if (!messages_to_send.empty()) 142 if (!messages_to_send.empty())
142 frame_token = frame_swap_message_queue_->AllocateFrameToken(); 143 frame_token = frame_swap_message_queue_->AllocateFrameToken();
143 frame.metadata.frame_token = frame_token; 144 frame.metadata.frame_token = frame_token;
144 sink_->SubmitCompositorFrame(local_surface_id_, std::move(frame)); 145 sink_->SubmitCompositorFrame(local_surface_id_, std::move(frame));
145 if (frame_token) { 146 if (frame_token) {
146 message_sender_->Send(new ViewHostMsg_FrameSwapMessages( 147 message_sender_->Send(new ViewHostMsg_FrameSwapMessages(
147 routing_id_, frame_token, messages_to_send)); 148 routing_id_, frame_token, messages_to_send));
148 } 149 }
149 // ~send_message_scope. 150 // ~send_message_scope.
150 } 151 }
151 } 152 }
152 153
154 void RendererCompositorFrameSink::BeginFrameDidNotProduceFrame(
155 const cc::BeginFrameAck& ack) {
156 DCHECK(!ack.has_damage);
157 DCHECK_LE(cc::BeginFrameArgs::kStartingFrameNumber, ack.sequence_number);
158 sink_->BeginFrameDidNotProduceFrame(ack);
159 }
160
153 void RendererCompositorFrameSink::OnMessageReceived( 161 void RendererCompositorFrameSink::OnMessageReceived(
154 const IPC::Message& message) { 162 const IPC::Message& message) {
155 DCHECK(thread_checker_.CalledOnValidThread()); 163 DCHECK(thread_checker_.CalledOnValidThread());
156 IPC_BEGIN_MESSAGE_MAP(RendererCompositorFrameSink, message) 164 IPC_BEGIN_MESSAGE_MAP(RendererCompositorFrameSink, message)
157 IPC_MESSAGE_HANDLER(ViewMsg_BeginFrame, OnBeginFrameIPC) 165 IPC_MESSAGE_HANDLER(ViewMsg_BeginFrame, OnBeginFrameIPC)
158 IPC_END_MESSAGE_MAP() 166 IPC_END_MESSAGE_MAP()
159 } 167 }
160 168
161 void RendererCompositorFrameSink::OnBeginFrameIPC( 169 void RendererCompositorFrameSink::OnBeginFrameIPC(
162 const cc::BeginFrameArgs& args) { 170 const cc::BeginFrameArgs& args) {
(...skipping 61 matching lines...) Expand 10 before | Expand all | Expand 10 after
224 232
225 void RendererCompositorFrameSink::ReclaimResources( 233 void RendererCompositorFrameSink::ReclaimResources(
226 const cc::ReturnedResourceArray& resources) { 234 const cc::ReturnedResourceArray& resources) {
227 client_->ReclaimResources(resources); 235 client_->ReclaimResources(resources);
228 } 236 }
229 237
230 void RendererCompositorFrameSink::OnNeedsBeginFrames(bool needs_begin_frames) { 238 void RendererCompositorFrameSink::OnNeedsBeginFrames(bool needs_begin_frames) {
231 sink_->SetNeedsBeginFrame(needs_begin_frames); 239 sink_->SetNeedsBeginFrame(needs_begin_frames);
232 } 240 }
233 241
234 void RendererCompositorFrameSink::OnDidFinishFrame(
235 const cc::BeginFrameAck& ack) {
236 DCHECK_LE(cc::BeginFrameArgs::kStartingFrameNumber, ack.sequence_number);
237 // If there was damage, ViewHostMsg_SwapCompositorFrame includes the ack.
238 if (!ack.has_damage)
239 sink_->BeginFrameDidNotSwap(ack);
240 }
241
242 void RendererCompositorFrameSink::EstablishMojoConnection() { 242 void RendererCompositorFrameSink::EstablishMojoConnection() {
243 cc::mojom::MojoCompositorFrameSinkPtr sink; 243 cc::mojom::MojoCompositorFrameSinkPtr sink;
244 cc::mojom::MojoCompositorFrameSinkRequest sink_request = 244 cc::mojom::MojoCompositorFrameSinkRequest sink_request =
245 mojo::MakeRequest(&sink); 245 mojo::MakeRequest(&sink);
246 cc::mojom::MojoCompositorFrameSinkClientPtr sink_client; 246 cc::mojom::MojoCompositorFrameSinkClientPtr sink_client;
247 sink_client_request_ = mojo::MakeRequest(&sink_client); 247 sink_client_request_ = mojo::MakeRequest(&sink_client);
248 RenderThreadImpl::current()->GetFrameSinkProvider()->CreateForWidget( 248 RenderThreadImpl::current()->GetFrameSinkProvider()->CreateForWidget(
249 routing_id_, std::move(sink_request), std::move(sink_client)); 249 routing_id_, std::move(sink_request), std::move(sink_client));
250 sink_ptr_info_ = sink.PassInterface(); 250 sink_ptr_info_ = sink.PassInterface();
251 } 251 }
252 252
253 } // namespace content 253 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698