Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1485)

Side by Side Diff: content/renderer/gpu/renderer_compositor_frame_sink.cc

Issue 2888043004: [cc] Add and plumb CFS::DidNotProduceFrame. (Closed)
Patch Set: address nits, rename to DidNotProduceFrame. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/renderer/gpu/renderer_compositor_frame_sink.h" 5 #include "content/renderer/gpu/renderer_compositor_frame_sink.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/command_line.h" 9 #include "base/command_line.h"
10 #include "base/location.h" 10 #include "base/location.h"
(...skipping 105 matching lines...) Expand 10 before | Expand all | Expand 10 after
116 compositor_frame_sink_filter_->RemoveHandlerOnCompositorThread( 116 compositor_frame_sink_filter_->RemoveHandlerOnCompositorThread(
117 routing_id_, compositor_frame_sink_filter_handler_); 117 routing_id_, compositor_frame_sink_filter_handler_);
118 sink_.reset(); 118 sink_.reset();
119 sink_client_binding_.Close(); 119 sink_client_binding_.Close();
120 cc::CompositorFrameSink::DetachFromClient(); 120 cc::CompositorFrameSink::DetachFromClient();
121 } 121 }
122 122
123 void RendererCompositorFrameSink::SubmitCompositorFrame( 123 void RendererCompositorFrameSink::SubmitCompositorFrame(
124 cc::CompositorFrame frame) { 124 cc::CompositorFrame frame) {
125 // We should only submit CompositorFrames with valid BeginFrameAcks. 125 // We should only submit CompositorFrames with valid BeginFrameAcks.
126 DCHECK(frame.metadata.begin_frame_ack.has_damage);
126 DCHECK_LE(cc::BeginFrameArgs::kStartingFrameNumber, 127 DCHECK_LE(cc::BeginFrameArgs::kStartingFrameNumber,
127 frame.metadata.begin_frame_ack.sequence_number); 128 frame.metadata.begin_frame_ack.sequence_number);
128 auto new_surface_properties = 129 auto new_surface_properties =
129 RenderWidgetSurfaceProperties::FromCompositorFrame(frame); 130 RenderWidgetSurfaceProperties::FromCompositorFrame(frame);
130 if (!local_surface_id_.is_valid() || 131 if (!local_surface_id_.is_valid() ||
131 new_surface_properties != current_surface_properties_) { 132 new_surface_properties != current_surface_properties_) {
132 local_surface_id_ = id_allocator_.GenerateId(); 133 local_surface_id_ = id_allocator_.GenerateId();
133 current_surface_properties_ = new_surface_properties; 134 current_surface_properties_ = new_surface_properties;
134 } 135 }
135 136
(...skipping 11 matching lines...) Expand all
147 frame.metadata.frame_token = frame_token; 148 frame.metadata.frame_token = frame_token;
148 sink_->SubmitCompositorFrame(local_surface_id_, std::move(frame)); 149 sink_->SubmitCompositorFrame(local_surface_id_, std::move(frame));
149 if (frame_token) { 150 if (frame_token) {
150 message_sender_->Send(new ViewHostMsg_FrameSwapMessages( 151 message_sender_->Send(new ViewHostMsg_FrameSwapMessages(
151 routing_id_, frame_token, messages_to_send)); 152 routing_id_, frame_token, messages_to_send));
152 } 153 }
153 // ~send_message_scope. 154 // ~send_message_scope.
154 } 155 }
155 } 156 }
156 157
158 void RendererCompositorFrameSink::DidNotProduceFrame(
159 const cc::BeginFrameAck& ack) {
160 DCHECK(!ack.has_damage);
161 DCHECK_LE(cc::BeginFrameArgs::kStartingFrameNumber, ack.sequence_number);
162 sink_->DidNotProduceFrame(ack);
163 }
164
157 void RendererCompositorFrameSink::OnMessageReceived( 165 void RendererCompositorFrameSink::OnMessageReceived(
158 const IPC::Message& message) { 166 const IPC::Message& message) {
159 DCHECK(thread_checker_.CalledOnValidThread()); 167 DCHECK(thread_checker_.CalledOnValidThread());
160 IPC_BEGIN_MESSAGE_MAP(RendererCompositorFrameSink, message) 168 IPC_BEGIN_MESSAGE_MAP(RendererCompositorFrameSink, message)
161 IPC_MESSAGE_HANDLER(ViewMsg_BeginFrame, OnBeginFrameIPC) 169 IPC_MESSAGE_HANDLER(ViewMsg_BeginFrame, OnBeginFrameIPC)
162 IPC_END_MESSAGE_MAP() 170 IPC_END_MESSAGE_MAP()
163 } 171 }
164 172
165 void RendererCompositorFrameSink::OnBeginFrameIPC( 173 void RendererCompositorFrameSink::OnBeginFrameIPC(
166 const cc::BeginFrameArgs& args) { 174 const cc::BeginFrameArgs& args) {
(...skipping 14 matching lines...) Expand all
181 189
182 void RendererCompositorFrameSink::ReclaimResources( 190 void RendererCompositorFrameSink::ReclaimResources(
183 const cc::ReturnedResourceArray& resources) { 191 const cc::ReturnedResourceArray& resources) {
184 client_->ReclaimResources(resources); 192 client_->ReclaimResources(resources);
185 } 193 }
186 194
187 void RendererCompositorFrameSink::OnNeedsBeginFrames(bool needs_begin_frames) { 195 void RendererCompositorFrameSink::OnNeedsBeginFrames(bool needs_begin_frames) {
188 sink_->SetNeedsBeginFrame(needs_begin_frames); 196 sink_->SetNeedsBeginFrame(needs_begin_frames);
189 } 197 }
190 198
191 void RendererCompositorFrameSink::OnDidFinishFrame(
192 const cc::BeginFrameAck& ack) {
193 DCHECK_LE(cc::BeginFrameArgs::kStartingFrameNumber, ack.sequence_number);
194 // If there was damage, ViewHostMsg_SwapCompositorFrame includes the ack.
195 if (!ack.has_damage)
196 sink_->BeginFrameDidNotSwap(ack);
197 }
198
199 void RendererCompositorFrameSink::EstablishMojoConnection() { 199 void RendererCompositorFrameSink::EstablishMojoConnection() {
200 cc::mojom::MojoCompositorFrameSinkPtr sink; 200 cc::mojom::MojoCompositorFrameSinkPtr sink;
201 cc::mojom::MojoCompositorFrameSinkRequest sink_request = 201 cc::mojom::MojoCompositorFrameSinkRequest sink_request =
202 mojo::MakeRequest(&sink); 202 mojo::MakeRequest(&sink);
203 cc::mojom::MojoCompositorFrameSinkClientPtr sink_client; 203 cc::mojom::MojoCompositorFrameSinkClientPtr sink_client;
204 sink_client_request_ = mojo::MakeRequest(&sink_client); 204 sink_client_request_ = mojo::MakeRequest(&sink_client);
205 RenderThreadImpl::current()->GetFrameSinkProvider()->CreateForWidget( 205 RenderThreadImpl::current()->GetFrameSinkProvider()->CreateForWidget(
206 routing_id_, std::move(sink_request), std::move(sink_client)); 206 routing_id_, std::move(sink_request), std::move(sink_client));
207 sink_ptr_info_ = sink.PassInterface(); 207 sink_ptr_info_ = sink.PassInterface();
208 } 208 }
209 209
210 } // namespace content 210 } // namespace content
OLDNEW
« no previous file with comments | « content/renderer/gpu/renderer_compositor_frame_sink.h ('k') | services/ui/public/cpp/client_compositor_frame_sink.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698