Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Side by Side Diff: services/ui/public/cpp/client_compositor_frame_sink.cc

Issue 2888043004: [cc] Add and plumb CFS::DidNotProduceFrame. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "services/ui/public/cpp/client_compositor_frame_sink.h" 5 #include "services/ui/public/cpp/client_compositor_frame_sink.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/command_line.h" 8 #include "base/command_line.h"
9 #include "base/memory/ptr_util.h" 9 #include "base/memory/ptr_util.h"
10 #include "cc/base/switches.h" 10 #include "cc/base/switches.h"
(...skipping 60 matching lines...) Expand 10 before | Expand all | Expand 10 after
71 local_surface_id_ = local_surface_id; 71 local_surface_id_ = local_surface_id;
72 } 72 }
73 73
74 void ClientCompositorFrameSink::SubmitCompositorFrame( 74 void ClientCompositorFrameSink::SubmitCompositorFrame(
75 cc::CompositorFrame frame) { 75 cc::CompositorFrame frame) {
76 DCHECK(thread_checker_); 76 DCHECK(thread_checker_);
77 DCHECK(thread_checker_->CalledOnValidThread()); 77 DCHECK(thread_checker_->CalledOnValidThread());
78 if (!compositor_frame_sink_) 78 if (!compositor_frame_sink_)
79 return; 79 return;
80 80
81 DCHECK(frame.metadata.begin_frame_ack.has_damage);
81 DCHECK_LE(cc::BeginFrameArgs::kStartingFrameNumber, 82 DCHECK_LE(cc::BeginFrameArgs::kStartingFrameNumber,
82 frame.metadata.begin_frame_ack.sequence_number); 83 frame.metadata.begin_frame_ack.sequence_number);
83 84
84 gfx::Size frame_size = frame.render_pass_list.back()->output_rect.size(); 85 gfx::Size frame_size = frame.render_pass_list.back()->output_rect.size();
85 if (!enable_surface_synchronization_ && 86 if (!enable_surface_synchronization_ &&
86 (!local_surface_id_.is_valid() || 87 (!local_surface_id_.is_valid() ||
87 frame_size != last_submitted_frame_size_)) { 88 frame_size != last_submitted_frame_size_)) {
88 local_surface_id_ = id_allocator_.GenerateId(); 89 local_surface_id_ = id_allocator_.GenerateId();
89 } 90 }
90 compositor_frame_sink_->SubmitCompositorFrame(local_surface_id_, 91 compositor_frame_sink_->SubmitCompositorFrame(local_surface_id_,
91 std::move(frame)); 92 std::move(frame));
92 last_submitted_frame_size_ = frame_size; 93 last_submitted_frame_size_ = frame_size;
93 } 94 }
94 95
96 void ClientCompositorFrameSink::BeginFrameDidNotProduceFrame(
97 const cc::BeginFrameAck& ack) {
98 DCHECK(!ack.has_damage);
99 DCHECK_LE(cc::BeginFrameArgs::kStartingFrameNumber, ack.sequence_number);
100 compositor_frame_sink_->BeginFrameDidNotProduceFrame(ack);
101 }
102
95 ClientCompositorFrameSink::ClientCompositorFrameSink( 103 ClientCompositorFrameSink::ClientCompositorFrameSink(
96 const cc::FrameSinkId& frame_sink_id, 104 const cc::FrameSinkId& frame_sink_id,
97 scoped_refptr<cc::ContextProvider> context_provider, 105 scoped_refptr<cc::ContextProvider> context_provider,
98 gpu::GpuMemoryBufferManager* gpu_memory_buffer_manager, 106 gpu::GpuMemoryBufferManager* gpu_memory_buffer_manager,
99 cc::mojom::MojoCompositorFrameSinkPtrInfo compositor_frame_sink_info, 107 cc::mojom::MojoCompositorFrameSinkPtrInfo compositor_frame_sink_info,
100 cc::mojom::MojoCompositorFrameSinkClientRequest client_request) 108 cc::mojom::MojoCompositorFrameSinkClientRequest client_request)
101 : cc::CompositorFrameSink(std::move(context_provider), 109 : cc::CompositorFrameSink(std::move(context_provider),
102 nullptr, 110 nullptr,
103 gpu_memory_buffer_manager, 111 gpu_memory_buffer_manager,
104 nullptr), 112 nullptr),
(...skipping 27 matching lines...) Expand all
132 if (!client_) 140 if (!client_)
133 return; 141 return;
134 client_->ReclaimResources(resources); 142 client_->ReclaimResources(resources);
135 } 143 }
136 144
137 void ClientCompositorFrameSink::OnNeedsBeginFrames(bool needs_begin_frames) { 145 void ClientCompositorFrameSink::OnNeedsBeginFrames(bool needs_begin_frames) {
138 compositor_frame_sink_->SetNeedsBeginFrame(needs_begin_frames); 146 compositor_frame_sink_->SetNeedsBeginFrame(needs_begin_frames);
139 } 147 }
140 148
141 void ClientCompositorFrameSink::OnDidFinishFrame(const cc::BeginFrameAck& ack) { 149 void ClientCompositorFrameSink::OnDidFinishFrame(const cc::BeginFrameAck& ack) {
142 // If there was damage, the submitted CompositorFrame includes the ack.
143 if (!ack.has_damage)
144 compositor_frame_sink_->BeginFrameDidNotSwap(ack);
145 } 150 }
146 151
147 ClientCompositorFrameSinkBinding::~ClientCompositorFrameSinkBinding() {} 152 ClientCompositorFrameSinkBinding::~ClientCompositorFrameSinkBinding() {}
148 153
149 ClientCompositorFrameSinkBinding::ClientCompositorFrameSinkBinding( 154 ClientCompositorFrameSinkBinding::ClientCompositorFrameSinkBinding(
150 cc::mojom::MojoCompositorFrameSinkRequest compositor_frame_sink_request, 155 cc::mojom::MojoCompositorFrameSinkRequest compositor_frame_sink_request,
151 cc::mojom::MojoCompositorFrameSinkClientPtrInfo 156 cc::mojom::MojoCompositorFrameSinkClientPtrInfo
152 compositor_frame_sink_client) 157 compositor_frame_sink_client)
153 : compositor_frame_sink_request_(std::move(compositor_frame_sink_request)), 158 : compositor_frame_sink_request_(std::move(compositor_frame_sink_request)),
154 compositor_frame_sink_client_(std::move(compositor_frame_sink_client)) {} 159 compositor_frame_sink_client_(std::move(compositor_frame_sink_client)) {}
155 160
156 cc::mojom::MojoCompositorFrameSinkRequest 161 cc::mojom::MojoCompositorFrameSinkRequest
157 ClientCompositorFrameSinkBinding::TakeFrameSinkRequest() { 162 ClientCompositorFrameSinkBinding::TakeFrameSinkRequest() {
158 return std::move(compositor_frame_sink_request_); 163 return std::move(compositor_frame_sink_request_);
159 } 164 }
160 165
161 cc::mojom::MojoCompositorFrameSinkClientPtrInfo 166 cc::mojom::MojoCompositorFrameSinkClientPtrInfo
162 ClientCompositorFrameSinkBinding::TakeFrameSinkClient() { 167 ClientCompositorFrameSinkBinding::TakeFrameSinkClient() {
163 return std::move(compositor_frame_sink_client_); 168 return std::move(compositor_frame_sink_client_);
164 } 169 }
165 170
166 } // namespace ui 171 } // namespace ui
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698