Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(538)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: content/common/browser_plugin/browser_plugin_messages.h

Issue 2887973002: Fix an IME regression for <webview> due to missing IPC message param (Closed)
Patch Set: Rebased Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/browser_plugin/browser_plugin_guest.cc ('k') | content/renderer/browser_plugin/browser_plugin.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/common/browser_plugin/browser_plugin_messages.h
diff --git a/content/common/browser_plugin/browser_plugin_messages.h b/content/common/browser_plugin/browser_plugin_messages.h
index 0ddd402aafd7b4d0a282a40377212e189d3a6984..515d74898107c60e933d976ca56f9a3e22378739 100644
--- a/content/common/browser_plugin/browser_plugin_messages.h
+++ b/content/common/browser_plugin/browser_plugin_messages.h
@@ -58,7 +58,10 @@ IPC_STRUCT_END()
// These messages are from the embedder to the browser process.
// Most messages from the embedder to the browser process are CONTROL because
// they are routed to the appropriate BrowserPluginGuest based on the
-// browser_plugin_instance_id which is unique per embedder process.
+// |browser_plugin_instance_id| which is unique per embedder process.
+// |browser_plugin_instance_id| is only used by BrowserPluginMessageFilter to
+// find the right BrowserPluginGuest. It should not be needed by the final IPC
+// handler.
// This message is sent from BrowserPlugin to BrowserPluginGuest to issue an
// edit command.
@@ -89,7 +92,8 @@ IPC_MESSAGE_CONTROL5(
// This message is sent from BrowserPlugin to BrowserPluginGuest to notify that
// inserting the current composition is requested.
-IPC_MESSAGE_CONTROL1(BrowserPluginHostMsg_ImeFinishComposingText,
+IPC_MESSAGE_CONTROL2(BrowserPluginHostMsg_ImeFinishComposingText,
+ int /* browser_plugin_instance_id */,
bool /* keep selection */)
// Deletes the current selection plus the specified number of characters before
« no previous file with comments | « content/browser/browser_plugin/browser_plugin_guest.cc ('k') | content/renderer/browser_plugin/browser_plugin.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698