chrome/browser/safe_browsing/client_side_detection_service_unittest.cc - Issue 2887843002: Replace BrowserThread::FILE in safe browsing with task scheduler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/client_side_detection_service_unittest.cc

Issue 2887843002: Replace BrowserThread::FILE in safe browsing with task scheduler. (Closed)

Patch Set: Switch SingleThread->SequencedTaskRunner per Gab's request. Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_fetcher_win.cc ('k') | chrome/browser/safe_browsing/download_feedback_service_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/client_side_detection_service_unittest.cc

diff --git a/chrome/browser/safe_browsing/client_side_detection_service_unittest.cc b/chrome/browser/safe_browsing/client_side_detection_service_unittest.cc

index b2a48898d586b41c29300212195005b06d68ab6d..ddf6a8d07c7a88b11edc6adc493c071b5d96ee15 100644

--- a/chrome/browser/safe_browsing/client_side_detection_service_unittest.cc

+++ b/chrome/browser/safe_browsing/client_side_detection_service_unittest.cc

@@ -70,8 +70,6 @@ class MockClientSideDetectionService : public ClientSideDetectionService {

class ClientSideDetectionServiceTest : public testing::Test {

protected:

void SetUp() override {

- file_thread_.reset(new content::TestBrowserThread(BrowserThread::FILE,

- &msg_loop_));

factory_.reset(new net::FakeURLFetcherFactory(NULL));

browser_thread_.reset(new content::TestBrowserThread(BrowserThread::UI,

&msg_loop_));

@@ -80,7 +78,6 @@ class ClientSideDetectionServiceTest : public testing::Test {

void TearDown() override {

base::RunLoop().RunUntilIdle();

csd_service_.reset();

- file_thread_.reset();

browser_thread_.reset();

}

@@ -252,7 +249,6 @@ class ClientSideDetectionServiceTest : public testing::Test {

}

std::unique_ptr<content::TestBrowserThread> browser_thread_;

- std::unique_ptr<content::TestBrowserThread> file_thread_;

gab 2017/06/06 14:34:53 I'm surprised this test doesn't need to add a Scop

Sigurður Ásgeirsson 2017/06/06 14:45:01 Yeah, looks like - I guess this'd start flaking if

std::unique_ptr<base::FieldTrialList> field_trials_;

GURL phishing_url_;