Issue 2887803002: SendAlgorithmTest should set pacing consistently. Test only.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2887803002: SendAlgorithmTest should set pacing consistently. Test only. (Closed)

Created:
3 years, 7 months ago by Victor Vasiliev

Modified:
3 years, 7 months ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org

Target Ref:
refs/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

SendAlgorithmTest should set pacing consistently. Test only. The SentPacketManager should set "UsingPacing" for the SendAlgorithm, depending on the congestion-control type. Unfortunately, this is currently only done if the user calls SetFromConfig to set the congestion-control type. Setting the SendAlgorithm directly can result in a having a congestion-control algorithm that is incompatible with pacing, but also has UsingPacing set to true. This is a temporary fix, until we fix b/38146609. Because of that bug, the rest of the code is a bit inconsistent on where/when pacing gets set. Merge internal change: 155528093 R=rch@chromium.org BUG=

Patch Set 1 #

Created: 3 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+17 lines, -1 line)			Patch
M	net/quic/core/congestion_control/send_algorithm_test.cc	View	1 chunk	+7 lines, -1 line	0 comments	Download
M	net/quic/test_tools/quic_sent_packet_manager_peer.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	net/quic/test_tools/quic_sent_packet_manager_peer.cc	View	1 chunk	+7 lines, -0 lines	0 comments	Download

Depends on Patchset:

Issue 2881423002 Patch 1

Dependent Patchsets:

Issue 2886843002 Patch 1

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages