Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Side by Side Diff: src/setup-isolate-deserialize.cc

Issue 2887783002: [gn] Allow building a snapshot with unwinding information. (Closed)
Patch Set: Fix assertion in stub-cache.cc Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/ic/stub-cache.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2017 the V8 project authors. All rights reserved. 1 // Copyright 2017 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/setup-isolate.h" 5 #include "src/setup-isolate.h"
6 6
7 #include "src/base/logging.h" 7 #include "src/base/logging.h"
8 #include "src/interpreter/interpreter.h" 8 #include "src/interpreter/interpreter.h"
9 #include "src/isolate.h" 9 #include "src/isolate.h"
10 #include "src/ostreams.h" 10 #include "src/ostreams.h"
11 11
12 namespace v8 { 12 namespace v8 {
13 namespace internal { 13 namespace internal {
14 14
15 void SetupIsolateDelegate::SetupBuiltins(Isolate* isolate, 15 void SetupIsolateDelegate::SetupBuiltins(Isolate* isolate,
16 bool create_heap_objects) { 16 bool create_heap_objects) {
17 DCHECK(!create_heap_objects); 17 DCHECK(!create_heap_objects);
18 // No actual work to be done; builtins will be deserialized from the snapshot. 18 // No actual work to be done; builtins will be deserialized from the snapshot.
19 } 19 }
20 20
21 void SetupIsolateDelegate::SetupInterpreter( 21 void SetupIsolateDelegate::SetupInterpreter(
22 interpreter::Interpreter* interpreter, bool create_heap_objects) { 22 interpreter::Interpreter* interpreter, bool create_heap_objects) {
23 #if defined(V8_USE_SNAPSHOT) && !defined(V8_USE_SNAPSHOT_WITH_UNWINDING_INFO)
24 if (FLAG_perf_prof_unwinding_info) {
25 OFStream os(stdout);
26 os << "Warning: The --perf-prof-unwinding-info flag can be passed at "
27 "mksnapshot time to get better results."
28 << std::endl;
29 }
30 #endif
23 DCHECK(interpreter->IsDispatchTableInitialized()); 31 DCHECK(interpreter->IsDispatchTableInitialized());
24 } 32 }
25 33
26 } // namespace internal 34 } // namespace internal
27 } // namespace v8 35 } // namespace v8
OLDNEW
« no previous file with comments | « src/ic/stub-cache.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698