Removes usage of native base::android::GetApplicationContext()

Removes usage of native base::android::GetApplicationContext()

BUG=webrtc:7665

[henrika_webrtc, 2017-05-16 13:53:19]

Description was changed from

==========
Removes usage of native base::android::GetApplicationContext()

Removes usage of native base::android::GetApplicationContext()


getting started

BUG=
==========

to

==========
Removes usage of native base::android::GetApplicationContext()

BUG=webrtc:7665
==========

[henrika_webrtc, 2017-05-16 13:53:19]

henrika@webrtc.org changed reviewers:
+ sakal@webrtc.org

[henrika_webrtc, 2017-05-17 09:21:06]

henrika@webrtc.org changed reviewers:
+ magjed@webrtc.org

[henrika_webrtc, 2017-05-17 09:21:46]

PTAL

[kjellander_webrtc, 2017-05-17 11:30:24]

On 2017/05/17 09:21:46, henrika_webrtc wrote:
> PTAL

To make PS#2 to compile, I think you'll have to add a dependency to
//base:base_java in your //webrtc/modules/audio_device:audio_device target, e.g.
here:
https://cs.chromium.org/chromium/src/third_party/webrtc/modules/audio_device/...

Then, if you want to test if this fixes
https://bugs.chromium.org/p/webrtc/issues/detail?id=7665 you should patch a roll
CL that contains the Chromium change of
https://codereview.chromium.org/2847523002, e.g. you can use
https://codereview.webrtc.org/2884793003/ , then do a 'gclient sync' and build
for Android.

[henrika_webrtc, 2017-05-17 14:13:40]

Thanks Henrik, 

adding more feedback in the issue.

[sakal, 2017-05-18 07:12:54]

https://codereview.webrtc.org/2887723002/diff/40001/webrtc/modules/audio_devi...
File webrtc/modules/audio_device/BUILD.gn (right):

https://codereview.webrtc.org/2887723002/diff/40001/webrtc/modules/audio_devi...
webrtc/modules/audio_device/BUILD.gn:362: "//base:base_java",
I don't want to add this dependency. Depending on Chromium Java code would
increase the binary size of WebRTC unnecessarily.

https://codereview.webrtc.org/2887723002/diff/40001/webrtc/modules/audio_devi...
File
webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioManager.java
(right):

https://codereview.webrtc.org/2887723002/diff/40001/webrtc/modules/audio_devi...
webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioManager.java:163:
audioManager = (AudioManager)
ContextUtils.getApplicationContext().getSystemService(
Instead of using Chromium ContextUtils, I think we should cache the application
context in PeerConnectionFactory and add a
PeerConnectionFactory.getApplicationContext method.

[magjed_webrtc, 2017-05-31 09:42:41]

magjed@webrtc.org changed reviewers:
- magjed@webrtc.org