third_party/WebKit/public/platform/modules/payments/WebPaymentAppRequest.h - Issue 2887713002: PaymentHandler: Merge PaymentAppRequest and PaymentRequestEvent.

Side by Side Diff: third_party/WebKit/public/platform/modules/payments/WebPaymentAppRequest.h

Issue 2887713002: PaymentHandler: Merge PaymentAppRequest and PaymentRequestEvent. (Closed)

Patch Set: PaymentHandler: Merge PaymentAppRequest and PaymentRequestEvent. Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 // Copyright 2016 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef WebPaymentAppRequest_h	5 #ifndef WebPaymentAppRequest_h

6 #define WebPaymentAppRequest_h	6 #define WebPaymentAppRequest_h
	please use gerrit instead 2017/05/22 14:20:05 Delete or rename? Delete or rename? zino 2017/05/23 14:51:29 This struct is needed to pass payment app request Show quoted text On 2017/05/22 14:20:05, ಠ_ಠ wrote: > Delete or rename? This struct is needed to pass payment app request data from content side to the blink side. Currently, the service worker related feature is still in content side. So, we can not use mojom struct yet in blink side. Please see this comments in my previous patch: https://codereview.chromium.org/2528683002/#msg10 please use gerrit instead 2017/05/23 15:02:59 Aren't you removing everything named PaymentAppRe Show quoted text On 2017/05/23 14:51:29, zino wrote: > On 2017/05/22 14:20:05, ಠ_ಠ wrote: > > Delete or rename? > > This struct is needed to pass payment app request data from content side to the > blink side. > Currently, the service worker related feature is still in content side. So, we > can not use mojom struct yet in blink side. > > Please see this comments in my previous patch: > https://codereview.chromium.org/2528683002/#msg10 Aren't you removing everything named PaymentAppRequest* and replacing it with PaymentRequestEvent instead? zino 2017/05/23 15:15:17 The request data will be exposed as attributes of Show quoted text On 2017/05/23 15:02:59, ಠ_ಠ wrote: > On 2017/05/23 14:51:29, zino wrote: > > On 2017/05/22 14:20:05, ಠ_ಠ wrote: > > > Delete or rename? > > > > This struct is needed to pass payment app request data from content side to > the > > blink side. > > Currently, the service worker related feature is still in content side. So, we > > can not use mojom struct yet in blink side. > > > > Please see this comments in my previous patch: > > https://codereview.chromium.org/2528683002/#msg10 > > Aren't you removing everything named PaymentAppRequest and replacing it with > PaymentRequestEvent instead? The request data will be exposed as attributes of PaymentRequestEvent but this struct is not actual event. The event object is created in ServiceWorkerGlobalScope[1]. This public struct is just container to pass the request data such as origin and request id from content side to blink side. https://cs.chromium.org/chromium/src/third_party/WebKit/Source/web/ServiceWor... If we should rename this, I think PaymentRequestEventData is better. WDYT?
7	7

8 #include "public/platform/WebString.h"	8 #include "public/platform/WebString.h"

9 #include "public/platform/WebVector.h"	9 #include "public/platform/WebVector.h"

10 #include "public/platform/modules/payments/WebPaymentDetailsModifier.h"	10 #include "public/platform/modules/payments/WebPaymentDetailsModifier.h"

11 #include "public/platform/modules/payments/WebPaymentItem.h"	11 #include "public/platform/modules/payments/WebPaymentItem.h"

12 #include "public/platform/modules/payments/WebPaymentMethodData.h"	12 #include "public/platform/modules/payments/WebPaymentMethodData.h"

13	13

14 namespace blink {	14 namespace blink {

15	15

16 // https://w3c.github.io/webpayments-payment-apps-api/#idl-def-paymentapprequest	16 // https://w3c.github.io/webpayments-payment-apps-api/#idl-def-paymentapprequest

17 struct WebPaymentAppRequest {	17 struct WebPaymentAppRequest {

18 WebString origin;	18 WebString top_level_origin;

	19 WebString payment_request_origin;

	20 WebString payment_request_id;

19 WebVector<WebPaymentMethodData> method_data;	21 WebVector<WebPaymentMethodData> method_data;

20 WebPaymentItem total;	22 WebPaymentItem total;

21 WebVector<WebPaymentDetailsModifier> modifiers;	23 WebVector<WebPaymentDetailsModifier> modifiers;

22 WebString option_id;	24 WebString instrument_key;

23 };	25 };

24	26

25 } // namespace blink	27 } // namespace blink

26	28

27 #endif // WebPaymentAppRequest_h	29 #endif // WebPaymentAppRequest_h

OLD	NEW