third_party/WebKit/Source/modules/payments/PaymentAppRequest.idl - Issue 2887713002: PaymentHandler: Merge PaymentAppRequest and PaymentRequestEvent.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/modules/payments/PaymentAppRequest.idl

Issue 2887713002: PaymentHandler: Merge PaymentAppRequest and PaymentRequestEvent. (Closed)

Patch Set: PaymentHandler: Merge PaymentAppRequest and PaymentRequestEvent. Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« content/test/data/payments/payment_app.js ('K') | « third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt ('k') | third_party/WebKit/Source/modules/payments/PaymentAppRequestConversion.cpp » ('j') | third_party/WebKit/Source/modules/payments/PaymentRequestEvent.idl » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2016 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.
	nhiroki 2017/05/21 23:41:40 Why don't you remove this idl? Why don't you remove this idl? please use gerrit instead 2017/05/22 14:20:04 Seems like all of the PaymentAppRequest* should be Show quoted text On 2017/05/21 23:41:40, nhiroki (slow) wrote: > Why don't you remove this idl? Seems like all of the PaymentAppRequest* should be deleted or renamed into PaymentRequestEvent. zino* 2017/05/23 14:51:29 I think the PaymentRequestEvent should add a const Show quoted text On 2017/05/22 14:20:04, ಠ_ಠ wrote: > On 2017/05/21 23:41:40, nhiroki (slow) wrote: > > Why don't you remove this idl? > > Seems like all of the PaymentAppRequest* should be deleted or renamed into > PaymentRequestEvent*. I think the PaymentRequestEvent should add a constructor and init dictionary for compatibility with DOM events. So, I sent a pull request[1] to the spec and then left a comment here. Once the issue is resolved in spec side, I'll update this dictionary and add a new constructor. [1] https://github.com/w3c/payment-handler/pull/162
2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 // https://w3c.github.io/webpayments-payment-apps-api/#idl-def-paymentapprequest	5 // https://w3c.github.io/webpayments-payment-apps-api/#idl-def-paymentapprequest

6	6

7 dictionary PaymentAppRequest {	7 dictionary PaymentAppRequest {

8 DOMString origin;	8 DOMString topLevelOrigin;

	9 DOMString paymentRequestOrigin;

	10 DOMString paymentRequestId;

9 sequence<PaymentMethodData> methodData;	11 sequence<PaymentMethodData> methodData;

10 PaymentItem total;	12 PaymentItem total;

11 sequence<PaymentDetailsModifier> modifiers;	13 sequence<PaymentDetailsModifier> modifiers;

12 DOMString optionId;	14 DOMString instrumentKey;

13 };	15 };

OLD	NEW