Only collect Permission Action Reporting data in official builds

chrome/browser/permissions/permission_uma_util.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/permissions/permission_uma_util.h"
 
 #include <utility>
 
 #include "base/command_line.h"
 #include "base/metrics/histogram_macros.h"
@@ skipping 42 matching lines @@
     PERMISSION_BUBBLE_TYPE_UMA(gesture_metric_name, permission_bubble_type); \
   } else if (gesture_type == PermissionRequestGestureType::NO_GESTURE) {     \
     PERMISSION_BUBBLE_TYPE_UMA(no_gesture_metric_name,                       \
                                permission_bubble_type);                      \
   }
 
 using content::PermissionType;
 
 namespace {
 
+static bool gIsFakeOfficialBuildForTest = false;
+
 const std::string GetRapporMetric(ContentSettingsType permission,
                                   PermissionAction action) {
   std::string action_str;
   switch (action) {
     case PermissionAction::GRANTED:
       action_str = "Granted";
       break;
     case PermissionAction::DENIED:
       action_str = "Denied";
       break;
@@ skipping 497 matching lines @@
       break;
     // The user is not prompted for these permissions, thus there is no deny
     // recorded for them.
     default:
       NOTREACHED() << "PERMISSION "
                    << PermissionUtil::GetPermissionString(permission)
                    << " not accounted for";
   }
 }
 
+void PermissionUmaUtil::FakeOfficialBuildForTest() {
+  gIsFakeOfficialBuildForTest = true;

[vakh (use Gerrit instead), 2017/05/25 01:59:17]

Perhaps add a CHECK(false) here for official builds?

[benwells, 2017/05/25 02:03:37]

The CHECK below is just for an experiment, not to land. I don't think I want any
CHECK(false)'s in the final version.

+}
+
 bool PermissionUmaUtil::IsOptedIntoPermissionActionReporting(Profile* profile) {
   if (base::CommandLine::ForCurrentProcess()->HasSwitch(
           switches::kDisablePermissionActionReporting)) {
     return false;
   }
 
+  bool official_build = gIsFakeOfficialBuildForTest;
+#if defined(OFFICIAL_BUILD) && defined(GOOGLE_CHROME_BUILD)
+  official_build = true;
+  CHECK(false);

[vakh (use Gerrit instead), 2017/05/25 01:59:17]

I must be reading this incorrectly but it looks like this will always crash the
official builds. If that's the case, why bother setting official_build?

[benwells, 2017/05/25 02:03:37]

Sorry, this is just an experiment I'm doing to see if any of the CQ bots run in
this configuration. I would not land this!

+#endif
+
+  if (!official_build)
+    return false;
+
   DCHECK(profile);
   if (profile->GetProfileType() == Profile::INCOGNITO_PROFILE)
     return false;
   if (!profile->GetPrefs()->GetBoolean(prefs::kSafeBrowsingEnabled))
     return false;
 
   browser_sync::ProfileSyncService* profile_sync_service =
       ProfileSyncServiceFactory::GetForProfile(profile);
 
   // Do not report if profile can't get a profile sync service or sync cannot
@@ skipping 97 matching lines @@
 
   const std::string rappor_metric = GetRapporMetric(permission, action);
   rappor::RapporServiceImpl* rappor_service =
       g_browser_process->rappor_service();
   if (!rappor_metric.empty() && rappor_service) {
     rappor_service->RecordSampleString(
         rappor_metric, rappor::LOW_FREQUENCY_ETLD_PLUS_ONE_RAPPOR_TYPE,
         rappor::GetDomainAndRegistrySampleFromGURL(requesting_origin));
   }
 }