Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(626)

Unified Diff: third_party/WebKit/Source/web/WebViewImpl.cpp

Issue 2887523003: Introduced WebFactory and WebFactoryImpl for constructing web/ classes (Closed)
Patch Set: Added TODOs for review feedback Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/web/WebViewImpl.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/web/WebViewImpl.cpp
diff --git a/third_party/WebKit/Source/web/WebViewImpl.cpp b/third_party/WebKit/Source/web/WebViewImpl.cpp
index 8f98f9b1b381adbdd5ba2ea7b6a795937be7f23f..1d8216e1d1d018348829630c2dec2ab36dbf47e7 100644
--- a/third_party/WebKit/Source/web/WebViewImpl.cpp
+++ b/third_party/WebKit/Source/web/WebViewImpl.cpp
@@ -51,6 +51,7 @@
#include "core/events/UIEventWithKeyState.h"
#include "core/events/WebInputEventConversion.h"
#include "core/events/WheelEvent.h"
+#include "core/exported/WebFactory.h"
#include "core/exported/WebPluginContainerBase.h"
#include "core/frame/BrowserControls.h"
#include "core/frame/EventHandlerRegistry.h"
@@ -337,7 +338,7 @@ WebViewImpl::WebViewImpl(WebViewClient* client,
WebPageVisibilityState visibility_state)
: client_(client),
spell_check_client_(nullptr),
- chrome_client_impl_(ChromeClientImpl::Create(this)),
+ chrome_client_(WebFactory::GetInstance().CreateChromeClient(this)),
context_menu_client_impl_(this),
editor_client_impl_(this),
spell_checker_client_impl_(this),
@@ -386,7 +387,7 @@ WebViewImpl::WebViewImpl(WebViewClient* client,
last_frame_time_monotonic_(0),
override_compositor_visibility_(false) {
Page::PageClients page_clients;
- page_clients.chrome_client = chrome_client_impl_.Get();
+ page_clients.chrome_client = chrome_client_.Get();
page_clients.context_menu_client = &context_menu_client_impl_;
page_clients.editor_client = &editor_client_impl_;
page_clients.spell_checker_client = &spell_checker_client_impl_;
« no previous file with comments | « third_party/WebKit/Source/web/WebViewImpl.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698