third_party/WebKit/Source/web/BUILD.gn - Issue 2887523003: Introduced WebFactory and WebFactoryImpl for constructing web/ classes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/BUILD.gn

Issue 2887523003: Introduced WebFactory and WebFactoryImpl for constructing web/ classes (Closed)

Patch Set: Added TODOs for review feedback Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/BUILD.gn

diff --git a/third_party/WebKit/Source/web/BUILD.gn b/third_party/WebKit/Source/web/BUILD.gn

index e5bcf367c0466e6c6610cb68a90be077f6279e66..7db163bce45f71e47cd1f956d72e5bdfaf4bbaab 100644

--- a/third_party/WebKit/Source/web/BUILD.gn

+++ b/third_party/WebKit/Source/web/BUILD.gn

@@ -127,6 +127,8 @@ component("web") {

"WebEmbeddedWorkerImpl.cpp",

"WebEmbeddedWorkerImpl.h",

"WebExport.h",

+ "WebFactoryImpl.cpp",

+ "WebFactoryImpl.h",

"WebFormControlElement.cpp",

"WebFormElement.cpp",

"WebFormElementObserverImpl.cpp",