third_party/WebKit/Source/core/WebFactory.cpp - Issue 2887523003: Introduced WebFactory and WebFactoryImpl for constructing web/ classes

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/core/WebFactory.cpp

Issue 2887523003: Introduced WebFactory and WebFactoryImpl for constructing web/ classes (Closed)

Patch Set: Removed file from wrong branch Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2017 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "core/WebFactory.h"

	6 #include "platform/wtf/Assertions.h"

	7

	8 namespace blink {

	9

	10 WebFactory* WebFactory::factory_instance_ = nullptr;

	11

	12 WebFactory& WebFactory::GetInstance() {

	13 DCHECK(factory_instance_);

	14 return *factory_instance_;

	15 }

	16

	17 void WebFactory::SetInstance(WebFactory* factory) {

	18 DCHECK_EQ(nullptr, factory_instance_);

	19 DCHECK(factory);
	dcheng 2017/05/22 09:16:49 Nit: in Blink, it's more customary to pass never-n Nit: in Blink, it's more customary to pass never-null mutable pointers as mutable refs. sashab 2017/05/29 04:34:00 Done. Show quoted text On 2017/05/22 at 09:16:49, dcheng wrote: > Nit: in Blink, it's more customary to pass never-null mutable pointers as mutable refs. Done.
	20 factory_instance_ = factory;

	21 }

	22

	23 } // namespace blink

OLD	NEW