Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 2887523002: Avoid changing enabled features while the browser is already running.

Created:
3 years, 7 months ago by Łukasz Anforowicz
Modified:
3 years, 7 months ago
Reviewers:
CC:
chromium-reviews, extensions-reviews_chromium.org, creis+watch_chromium.org, vmpstr+watch_chromium.org, nasko+codewatch_chromium.org, jam, darin-cc_chromium.org, chromium-apps-reviews_chromium.org, danakj+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Avoid changing enabled features while the browser is already running. Changing enabled features while the browser is already running is inherently racey - the race is between the thread that changes the features (e.g. by test calling one of base::test::ScopedFeatureList::Init... methods on the main thread) and the thread that tries to read currently enabled features (e.g. by product code trying to see on the IO thread which features are enabled). BUG=722409 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -12 lines) Patch
M base/feature_list.h View 1 chunk +6 lines, -0 lines 0 comments Download
M base/feature_list.cc View 3 chunks +9 lines, -0 lines 0 comments Download
M chrome/browser/task_manager/providers/web_contents/subframe_task_browsertest.cc View 1 chunk +5 lines, -1 line 0 comments Download
M chrome/browser/ui/extensions/hosted_app_browsertest.cc View 1 chunk +5 lines, -1 line 0 comments Download
M chrome/test/base/in_process_browser_test.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M content/browser/frame_host/data_url_navigation_browsertest.cc View 1 chunk +20 lines, -5 lines 0 comments Download
M content/public/test/browser_test_base.cc View 2 chunks +2 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 5 (5 generated)
Łukasz Anforowicz
Description was changed from ========== Avoid changing enabled features while the browser is already running. ...
3 years, 7 months ago (2017-05-15 19:57:41 UTC) #1
Łukasz Anforowicz
The CQ bit was checked by lukasza@chromium.org to run a CQ dry run
3 years, 7 months ago (2017-05-16 00:00:30 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2887523002/1
3 years, 7 months ago (2017-05-16 00:01:42 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 7 months ago (2017-05-16 01:12:11 UTC) #4
commit-bot: I haz the power
3 years, 7 months ago (2017-05-16 01:12:12 UTC) #5
Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

Powered by Google App Engine
This is Rietveld 408576698