[sync] Scope BrowserListRouterHelper to browsers with a matching profile

chrome/browser/sync/sessions/sync_sessions_web_contents_router.h

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_SYNC_SESSIONS_SYNC_SESSIONS_WEB_CONTENTS_ROUTER_H_
 #define CHROME_BROWSER_SYNC_SESSIONS_SYNC_SESSIONS_WEB_CONTENTS_ROUTER_H_
 
 #include "base/callback_list.h"
 
 // Android has no BrowserList or TabStripModel, so we exclude code that refers
@@ skipping 44 matching lines @@
  private:
   void OnFaviconsChanged(const std::set<GURL>& page_urls, const GURL& icon_url);
 
   std::unique_ptr<base::CallbackList<void(const std::set<GURL>&,
                                           const GURL&)>::Subscription>
       favicon_changed_subscription_;
   syncer::SyncableService::StartSyncFlare flare_;
   LocalSessionEventHandler* handler_ = nullptr;
 
 #if !defined(OS_ANDROID)
+  friend class BrowserListRouterHelperTest;

[skym, 2017/05/15 20:58:01]

I'd prefer to not use friending for tests, when possible. It seems like the
first class way to do this would to make a MockLocalSessionEventHandler class,
right? Then inject that with SyncSessionsWebContentsRouter::StartRoutingTo. Then
any time a tab is modified, you should get events, right?

[Patrick Noland, 2017/05/15 21:56:51]

Done.

   std::unique_ptr<BrowserListRouterHelper> browser_list_helper_;
 #endif  // !defined(OS_ANDROID)
 
   DISALLOW_COPY_AND_ASSIGN(SyncSessionsWebContentsRouter);
 };
 
 }  // namespace sync_sessions
 
 #endif  // CHROME_BROWSER_SYNC_SESSIONS_SYNC_SESSIONS_WEB_CONTENTS_ROUTER_H_