Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Unified Diff: components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate.cc

Issue 2887423002: Add an about:flag to support alternative data saver features (Closed)
Patch Set: tbansal nits Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate.cc
diff --git a/components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate.cc b/components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate.cc
index 7a5f5dcc40fba7fac27a9805e25324372f900f4d..75becf17aea399c28c743e0e5316fa7e5dcf02e7 100644
--- a/components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate.cc
+++ b/components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate.cc
@@ -11,6 +11,7 @@
#include "base/memory/ptr_util.h"
#include "base/metrics/histogram_macros.h"
#include "base/strings/string_number_conversions.h"
+#include "base/strings/string_split.h"
#include "base/time/time.h"
#include "components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_stats.h"
#include "components/data_reduction_proxy/core/browser/data_reduction_proxy_config.h"
@@ -168,8 +169,17 @@ int64_t EstimateOriginalReceivedBytes(const net::URLRequest& request,
void VerifyHttpRequestHeaders(bool via_chrome_proxy,
const net::HttpRequestHeaders& headers) {
if (via_chrome_proxy) {
- DCHECK(headers.HasHeader(chrome_proxy_header()));
DCHECK(headers.HasHeader(chrome_proxy_ect_header()));
+ std::string chrome_proxy_header_value;
+ DCHECK(
+ headers.GetHeader(chrome_proxy_header(), &chrome_proxy_header_value));
+ // Check that only 1 "exp" directive is sent.
+ DCHECK_GT(3u, base::SplitStringUsingSubstr(chrome_proxy_header_value,
+ "exp=", base::TRIM_WHITESPACE,
+ base::SPLIT_WANT_ALL)
+ .size());
+ // Silence unused variable warning in release builds.
+ (void)chrome_proxy_header_value;
} else {
DCHECK(!headers.HasHeader(chrome_proxy_header()));
DCHECK(!headers.HasHeader(chrome_proxy_accept_transform_header()));
@@ -370,8 +380,6 @@ void DataReductionProxyNetworkDelegate::OnBeforeSendHeadersInternal(
data_reduction_proxy_request_options_->AddRequestHeader(headers, page_id);
- if (lofi_decider)
- lofi_decider->MaybeSetIgnorePreviewsBlacklistDirective(headers);
VerifyHttpRequestHeaders(true, *headers);
}

Powered by Google App Engine
This is Rietveld 408576698