Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Side by Side Diff: chrome/browser/about_flags.cc

Issue 2887423002: Add an about:flag to support alternative data saver features (Closed)
Patch Set: fixes Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/about_flags.h" 5 #include "chrome/browser/about_flags.h"
6 6
7 #include <iterator> 7 #include <iterator>
8 #include <map> 8 #include <map>
9 #include <set> 9 #include <set>
10 #include <utility> 10 #include <utility>
(...skipping 235 matching lines...) Expand 10 before | Expand all | Expand 10 after
246 data_reduction_proxy::switches::kDataReductionProxyLoFi, 246 data_reduction_proxy::switches::kDataReductionProxyLoFi,
247 data_reduction_proxy::switches::kDataReductionProxyLoFiValueCellularOnly}, 247 data_reduction_proxy::switches::kDataReductionProxyLoFiValueCellularOnly},
248 {flag_descriptions::kDataReductionProxyLoFiDisabled, 248 {flag_descriptions::kDataReductionProxyLoFiDisabled,
249 data_reduction_proxy::switches::kDataReductionProxyLoFi, 249 data_reduction_proxy::switches::kDataReductionProxyLoFi,
250 data_reduction_proxy::switches::kDataReductionProxyLoFiValueDisabled}, 250 data_reduction_proxy::switches::kDataReductionProxyLoFiValueDisabled},
251 {flag_descriptions::kDataReductionProxyLoFiSlowConnectionsOnly, 251 {flag_descriptions::kDataReductionProxyLoFiSlowConnectionsOnly,
252 data_reduction_proxy::switches::kDataReductionProxyLoFi, 252 data_reduction_proxy::switches::kDataReductionProxyLoFi,
253 data_reduction_proxy::switches:: 253 data_reduction_proxy::switches::
254 kDataReductionProxyLoFiValueSlowConnectionsOnly}}; 254 kDataReductionProxyLoFiValueSlowConnectionsOnly}};
255 255
256 const FeatureEntry::Choice kDataReductionProxyServerExperiment[] = {
257 {flags_ui::kGenericExperimentChoiceDefault, "", ""},
258 {flag_descriptions::kDataReductionProxyServerAlternative,
259 data_reduction_proxy::switches::kDataReductionProxyExperiment,
260 data_reduction_proxy::switches::kDataReductionProxyServerAlternative}};
261
256 const FeatureEntry::Choice kShowSavedCopyChoices[] = { 262 const FeatureEntry::Choice kShowSavedCopyChoices[] = {
257 {flags_ui::kGenericExperimentChoiceDefault, "", ""}, 263 {flags_ui::kGenericExperimentChoiceDefault, "", ""},
258 {flag_descriptions::kEnableShowSavedCopyPrimary, 264 {flag_descriptions::kEnableShowSavedCopyPrimary,
259 error_page::switches::kShowSavedCopy, 265 error_page::switches::kShowSavedCopy,
260 error_page::switches::kEnableShowSavedCopyPrimary}, 266 error_page::switches::kEnableShowSavedCopyPrimary},
261 {flag_descriptions::kEnableShowSavedCopySecondary, 267 {flag_descriptions::kEnableShowSavedCopySecondary,
262 error_page::switches::kShowSavedCopy, 268 error_page::switches::kShowSavedCopy,
263 error_page::switches::kEnableShowSavedCopySecondary}, 269 error_page::switches::kEnableShowSavedCopySecondary},
264 {flag_descriptions::kDisableShowSavedCopy, 270 {flag_descriptions::kDisableShowSavedCopy,
265 error_page::switches::kShowSavedCopy, 271 error_page::switches::kShowSavedCopy,
(...skipping 1619 matching lines...) Expand 10 before | Expand all | Expand 10 after
1885 #endif // OS_MACOSX 1891 #endif // OS_MACOSX
1886 {"data-reduction-proxy-lo-fi", 1892 {"data-reduction-proxy-lo-fi",
1887 flag_descriptions::kDataReductionProxyLoFiName, 1893 flag_descriptions::kDataReductionProxyLoFiName,
1888 flag_descriptions::kDataReductionProxyLoFiDescription, kOsAll, 1894 flag_descriptions::kDataReductionProxyLoFiDescription, kOsAll,
1889 MULTI_VALUE_TYPE(kDataReductionProxyLoFiChoices)}, 1895 MULTI_VALUE_TYPE(kDataReductionProxyLoFiChoices)},
1890 {"enable-data-reduction-proxy-lite-page", 1896 {"enable-data-reduction-proxy-lite-page",
1891 flag_descriptions::kEnableDataReductionProxyLitePageName, 1897 flag_descriptions::kEnableDataReductionProxyLitePageName,
1892 flag_descriptions::kEnableDataReductionProxyLitePageDescription, kOsAll, 1898 flag_descriptions::kEnableDataReductionProxyLitePageDescription, kOsAll,
1893 SINGLE_VALUE_TYPE( 1899 SINGLE_VALUE_TYPE(
1894 data_reduction_proxy::switches::kEnableDataReductionProxyLitePage)}, 1900 data_reduction_proxy::switches::kEnableDataReductionProxyLitePage)},
1901 {"enable-data-reduction-proxy-server-experiment",
1902 flag_descriptions::kEnableDataReductionProxyServerExperimentName,
1903 flag_descriptions::kEnableDataReductionProxyServerExperimentDescription,
1904 kOsAll, MULTI_VALUE_TYPE(kDataReductionProxyServerExperiment)},
1895 #if defined(OS_ANDROID) 1905 #if defined(OS_ANDROID)
1896 {"enable-data-reduction-proxy-savings-promo", 1906 {"enable-data-reduction-proxy-savings-promo",
1897 flag_descriptions::kEnableDataReductionProxySavingsPromoName, 1907 flag_descriptions::kEnableDataReductionProxySavingsPromoName,
1898 flag_descriptions::kEnableDataReductionProxySavingsPromoDescription, 1908 flag_descriptions::kEnableDataReductionProxySavingsPromoDescription,
1899 kOsAndroid, 1909 kOsAndroid,
1900 SINGLE_VALUE_TYPE(data_reduction_proxy::switches:: 1910 SINGLE_VALUE_TYPE(data_reduction_proxy::switches::
1901 kEnableDataReductionProxySavingsPromo)}, 1911 kEnableDataReductionProxySavingsPromo)},
1902 {"enable-data-reduction-proxy-main-menu", 1912 {"enable-data-reduction-proxy-main-menu",
1903 flag_descriptions::kEnableDataReductionProxyMainMenuName, 1913 flag_descriptions::kEnableDataReductionProxyMainMenuName,
1904 flag_descriptions::kEnableDataReductionProxyMainMenuDescription, 1914 flag_descriptions::kEnableDataReductionProxyMainMenuDescription,
(...skipping 1263 matching lines...) Expand 10 before | Expand all | Expand 10 after
3168 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0; 3178 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0;
3169 3179
3170 const FeatureEntry* GetFeatureEntries(size_t* count) { 3180 const FeatureEntry* GetFeatureEntries(size_t* count) {
3171 *count = arraysize(kFeatureEntries); 3181 *count = arraysize(kFeatureEntries);
3172 return kFeatureEntries; 3182 return kFeatureEntries;
3173 } 3183 }
3174 3184
3175 } // namespace testing 3185 } // namespace testing
3176 3186
3177 } // namespace about_flags 3187 } // namespace about_flags
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698