Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Side by Side Diff: chrome/browser/about_flags.cc

Issue 2887423002: Add an about:flag to support alternative data saver features (Closed)
Patch Set: enums feature Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/about_flags.h" 5 #include "chrome/browser/about_flags.h"
6 6
7 #include <iterator> 7 #include <iterator>
8 #include <map> 8 #include <map>
9 #include <set> 9 #include <set>
10 #include <utility> 10 #include <utility>
(...skipping 1874 matching lines...) Expand 10 before | Expand all | Expand 10 after
1885 #endif // OS_MACOSX 1885 #endif // OS_MACOSX
1886 {"data-reduction-proxy-lo-fi", 1886 {"data-reduction-proxy-lo-fi",
1887 flag_descriptions::kDataReductionProxyLoFiName, 1887 flag_descriptions::kDataReductionProxyLoFiName,
1888 flag_descriptions::kDataReductionProxyLoFiDescription, kOsAll, 1888 flag_descriptions::kDataReductionProxyLoFiDescription, kOsAll,
1889 MULTI_VALUE_TYPE(kDataReductionProxyLoFiChoices)}, 1889 MULTI_VALUE_TYPE(kDataReductionProxyLoFiChoices)},
1890 {"enable-data-reduction-proxy-lite-page", 1890 {"enable-data-reduction-proxy-lite-page",
1891 flag_descriptions::kEnableDataReductionProxyLitePageName, 1891 flag_descriptions::kEnableDataReductionProxyLitePageName,
1892 flag_descriptions::kEnableDataReductionProxyLitePageDescription, kOsAll, 1892 flag_descriptions::kEnableDataReductionProxyLitePageDescription, kOsAll,
1893 SINGLE_VALUE_TYPE( 1893 SINGLE_VALUE_TYPE(
1894 data_reduction_proxy::switches::kEnableDataReductionProxyLitePage)}, 1894 data_reduction_proxy::switches::kEnableDataReductionProxyLitePage)},
1895 {"enable-data-reduction-proxy-alternative-back-end",
tbansal1 2017/05/19 16:27:23 I still think this should be a dropdown flag (with
RyanSturm 2017/05/23 22:04:57 Done.
1896 flag_descriptions::kEnableDataReductionProxyAlternativeBackEndName,
1897 flag_descriptions::kEnableDataReductionProxyAlternativeBackEndDescription,
1898 kOsAll,
1899 FEATURE_VALUE_TYPE(data_reduction_proxy::features::
1900 kDataReductionProxyAlternativeBackEnd)},
1895 #if defined(OS_ANDROID) 1901 #if defined(OS_ANDROID)
1896 {"enable-data-reduction-proxy-savings-promo", 1902 {"enable-data-reduction-proxy-savings-promo",
1897 flag_descriptions::kEnableDataReductionProxySavingsPromoName, 1903 flag_descriptions::kEnableDataReductionProxySavingsPromoName,
1898 flag_descriptions::kEnableDataReductionProxySavingsPromoDescription, 1904 flag_descriptions::kEnableDataReductionProxySavingsPromoDescription,
1899 kOsAndroid, 1905 kOsAndroid,
1900 SINGLE_VALUE_TYPE(data_reduction_proxy::switches:: 1906 SINGLE_VALUE_TYPE(data_reduction_proxy::switches::
1901 kEnableDataReductionProxySavingsPromo)}, 1907 kEnableDataReductionProxySavingsPromo)},
1902 {"enable-data-reduction-proxy-main-menu", 1908 {"enable-data-reduction-proxy-main-menu",
1903 flag_descriptions::kEnableDataReductionProxyMainMenuName, 1909 flag_descriptions::kEnableDataReductionProxyMainMenuName,
1904 flag_descriptions::kEnableDataReductionProxyMainMenuDescription, 1910 flag_descriptions::kEnableDataReductionProxyMainMenuDescription,
(...skipping 1263 matching lines...) Expand 10 before | Expand all | Expand 10 after
3168 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0; 3174 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0;
3169 3175
3170 const FeatureEntry* GetFeatureEntries(size_t* count) { 3176 const FeatureEntry* GetFeatureEntries(size_t* count) {
3171 *count = arraysize(kFeatureEntries); 3177 *count = arraysize(kFeatureEntries);
3172 return kFeatureEntries; 3178 return kFeatureEntries;
3173 } 3179 }
3174 3180
3175 } // namespace testing 3181 } // namespace testing
3176 3182
3177 } // namespace about_flags 3183 } // namespace about_flags
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698