Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(404)

Unified Diff: content/renderer/media/webrtc/webrtc_media_stream_track_collection_unittest.cc

Issue 2887403003: WebRtcMediaStreamTrackMap added (Closed)
Patch Set: Removed death tests due to warning about death tests being unsafe with multiple threads Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/media/webrtc/webrtc_media_stream_track_collection_unittest.cc
diff --git a/content/renderer/media/webrtc/webrtc_media_stream_track_collection_unittest.cc b/content/renderer/media/webrtc/webrtc_media_stream_track_collection_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..748dac20c8f028156cede4a21fc38319389b3d24
--- /dev/null
+++ b/content/renderer/media/webrtc/webrtc_media_stream_track_collection_unittest.cc
@@ -0,0 +1,185 @@
+// Copyright (c) 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "content/renderer/media/webrtc/webrtc_media_stream_track_collection.h"
+
+#include <memory>
+
+#include "base/memory/ref_counted.h"
+#include "base/message_loop/message_loop.h"
+#include "base/run_loop.h"
+#include "base/single_thread_task_runner.h"
+#include "content/child/child_process.h"
+#include "content/renderer/media/media_stream_audio_source.h"
+#include "content/renderer/media/webrtc/mock_peer_connection_dependency_factory.h"
+#include "testing/gtest/include/gtest/gtest.h"
+#include "third_party/WebKit/public/platform/WebMediaStreamSource.h"
+#include "third_party/WebKit/public/platform/WebMediaStreamTrack.h"
+#include "third_party/WebKit/public/platform/WebString.h"
+#include "third_party/WebKit/public/web/WebHeap.h"
+
+namespace content {
+
+class WebRtcMediaStreamTrackCollectionTest : public ::testing::Test {
+ public:
+ void SetUp() override {
+ dependency_factory_.reset(new MockPeerConnectionDependencyFactory());
+ main_thread_ = base::ThreadTaskRunnerHandle::Get();
+ collection_ = new WebRtcMediaStreamTrackCollection(
+ dependency_factory_.get(), main_thread_);
+ }
+
+ void TearDown() override { blink::WebHeap::CollectAllGarbageForTesting(); }
+
+ blink::WebMediaStreamTrack CreateLocalTrack(const std::string& id) {
+ blink::WebMediaStreamSource web_source;
+ web_source.Initialize(
+ blink::WebString::FromUTF8(id), blink::WebMediaStreamSource::kTypeAudio,
+ blink::WebString::FromUTF8("local_audio_track"), false);
+ MediaStreamAudioSource* audio_source = new MediaStreamAudioSource(true);
+ // Takes ownership of |audio_source|.
+ web_source.SetExtraData(audio_source);
+
+ blink::WebMediaStreamTrack web_track;
+ web_track.Initialize(web_source.Id(), web_source);
+ audio_source->ConnectToTrack(web_track);
+ return web_track;
+ }
+
+ scoped_refptr<WebRtcMediaStreamTrackAdapter> GetOrCreateRemoteTrack(
+ webrtc::MediaStreamTrackInterface* webrtc_track) {
+ DCHECK(main_thread_->BelongsToCurrentThread());
+ scoped_refptr<WebRtcMediaStreamTrackAdapter> track;
+ dependency_factory_->GetWebRtcSignalingThread()->PostTask(
+ FROM_HERE, base::Bind(&WebRtcMediaStreamTrackCollectionTest::
+ GetOrCreateRemoteTrackOnSignalingThread,
+ base::Unretained(this), webrtc_track, &track));
+ RunMessageLoopsUntilIdle();
+ return track;
+ }
+
+ void GetOrCreateRemoteTrackOnSignalingThread(
+ webrtc::MediaStreamTrackInterface* webrtc_track,
+ scoped_refptr<WebRtcMediaStreamTrackAdapter>* track) {
+ DCHECK(dependency_factory_->GetWebRtcSignalingThread()
+ ->BelongsToCurrentThread());
+ *track = collection_->GetOrCreateRemoteTrack(webrtc_track);
+ }
+
+ // Runs message loops on the webrtc signaling thread and the main thread until
+ // idle.
+ void RunMessageLoopsUntilIdle() {
+ DCHECK(main_thread_->BelongsToCurrentThread());
+ base::WaitableEvent waitable_event(
+ base::WaitableEvent::ResetPolicy::MANUAL,
+ base::WaitableEvent::InitialState::NOT_SIGNALED);
+ dependency_factory_->GetWebRtcSignalingThread()->PostTask(
+ FROM_HERE, base::Bind(&WebRtcMediaStreamTrackCollectionTest::
+ RunMessageLoopUntilIdleOnSignalingThread,
+ base::Unretained(this), &waitable_event));
+ waitable_event.Wait();
+ base::RunLoop().RunUntilIdle();
+ }
+
+ void RunMessageLoopUntilIdleOnSignalingThread(
+ base::WaitableEvent* waitable_event) {
+ DCHECK(dependency_factory_->GetWebRtcSignalingThread()
+ ->BelongsToCurrentThread());
+ base::RunLoop().RunUntilIdle();
+ waitable_event->Signal();
+ }
+
+ protected:
+ // Message loop and child processes is needed for task queues and threading to
+ // work, as is necessary to create tracks and adapters.
+ base::MessageLoop message_loop_;
+ ChildProcess child_process_;
+
+ std::unique_ptr<MockPeerConnectionDependencyFactory> dependency_factory_;
+ scoped_refptr<base::SingleThreadTaskRunner> main_thread_;
+ scoped_refptr<WebRtcMediaStreamTrackCollection> collection_;
+};
+
+TEST_F(WebRtcMediaStreamTrackCollectionTest, AddAndRemoveLocalTrack) {
+ blink::WebMediaStreamTrack web_track = CreateLocalTrack("local_track");
+ scoped_refptr<WebRtcMediaStreamTrackAdapter> track =
+ collection_->GetOrCreateLocalTrack(web_track);
+ DCHECK(track);
+ EXPECT_TRUE(track->is_initialized());
+ EXPECT_EQ(track, collection_->GetLocalTrack(web_track.Id().Utf8()));
+ EXPECT_EQ(1u, collection_->GetLocalTrackCount());
+
+ // "GetOrCreate" for already existing track.
+ EXPECT_EQ(track, collection_->GetOrCreateLocalTrack(web_track));
+ EXPECT_EQ(1u, collection_->GetLocalTrackCount());
+
+ // Remove and uninitialize track. Must not hold references to track.
+ track = nullptr;
+ collection_->RemoveAndUninitializeLocalTrack(web_track.Id().Utf8());
+ EXPECT_EQ(0u, collection_->GetLocalTrackCount());
+ EXPECT_EQ(nullptr, collection_->GetLocalTrack(web_track.Id().Utf8()));
+ // Allow uninitialization of track to occur.
+ RunMessageLoopsUntilIdle();
+}
+
+TEST_F(WebRtcMediaStreamTrackCollectionTest, AddAndRemoveRemoteTrack) {
+ scoped_refptr<MockWebRtcAudioTrack> webrtc_track =
+ MockWebRtcAudioTrack::Create("remote_track");
+ scoped_refptr<WebRtcMediaStreamTrackAdapter> track =
+ GetOrCreateRemoteTrack(webrtc_track.get());
+ DCHECK(track);
+ EXPECT_TRUE(track->is_initialized());
+ EXPECT_EQ(track, collection_->GetRemoteTrack(webrtc_track->id()));
+ EXPECT_EQ(1u, collection_->GetRemoteTrackCount());
+
+ // "GetOrCreate" for already existing track.
+ EXPECT_EQ(track, GetOrCreateRemoteTrack(webrtc_track.get()));
+ EXPECT_EQ(1u, collection_->GetRemoteTrackCount());
+
+ // Remove and uninitialize track. Must not hold references to track.
+ track = nullptr;
+ collection_->RemoveAndUninitializeRemoteTrack(webrtc_track->id());
+ EXPECT_EQ(0u, collection_->GetRemoteTrackCount());
+ EXPECT_EQ(nullptr, collection_->GetRemoteTrack(webrtc_track->id()));
+ // Allow uninitialization of track to occur.
+ RunMessageLoopsUntilIdle();
+}
+
+TEST_F(WebRtcMediaStreamTrackCollectionTest, AddAndClearLocalAndRemoteTrack) {
+ // Local and remote tracks should be able to use the same id without conflict.
+ const char* id = "id";
+
+ // Add local track.
+ blink::WebMediaStreamTrack local_web_track = CreateLocalTrack(id);
+ scoped_refptr<WebRtcMediaStreamTrackAdapter> local_track =
+ collection_->GetOrCreateLocalTrack(local_web_track);
+ DCHECK(local_track);
+ EXPECT_TRUE(local_track->is_initialized());
+ EXPECT_EQ(local_track, collection_->GetLocalTrack(id));
+ EXPECT_EQ(1u, collection_->GetLocalTrackCount());
+
+ // Add remote track.
+ scoped_refptr<MockWebRtcAudioTrack> remote_webrtc_track =
+ MockWebRtcAudioTrack::Create(id);
+ scoped_refptr<WebRtcMediaStreamTrackAdapter> remote_track =
+ GetOrCreateRemoteTrack(remote_webrtc_track.get());
+ DCHECK(remote_track);
+ EXPECT_TRUE(remote_track->is_initialized());
+ EXPECT_EQ(remote_track, collection_->GetRemoteTrack(id));
+ EXPECT_NE(local_track, remote_track);
+ EXPECT_EQ(1u, collection_->GetRemoteTrackCount());
+
+ // Clear and uninitialize tracks. Must not hold references to tracks.
+ local_track = nullptr;
+ remote_track = nullptr;
+ collection_->ClearAndUninitializeTracks();
+ EXPECT_EQ(0u, collection_->GetLocalTrackCount());
+ EXPECT_EQ(0u, collection_->GetRemoteTrackCount());
+ EXPECT_EQ(nullptr, collection_->GetLocalTrack(id));
+ EXPECT_EQ(nullptr, collection_->GetRemoteTrack(id));
+ // Allow uninitialization of tracks to occur.
+ RunMessageLoopsUntilIdle();
+}
+
Guido Urdaneta 2017/05/22 16:14:49 Add a few extra tests to check what happens if, fo
hbos_chromium 2017/05/29 13:28:51 Done.
+} // namespace content

Powered by Google App Engine
This is Rietveld 408576698