chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/VrShellNavigationTest.java - Issue 2887383002: Show an infobar prompting the user to enter feedback when they exit VR

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/VrShellNavigationTest.java

Issue 2887383002: Show an infobar prompting the user to enter feedback when they exit VR (Closed)

Patch Set: add comments Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/VrFeedbackInfoBarTest.java ('k') | chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/VrUtils.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/VrShellNavigationTest.java

diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/VrShellNavigationTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/VrShellNavigationTest.java

index 6a3e47b2e41637d225e9cbe480aa7a97e14dc522..e067d4a34c578391639e3cc72bb4fec10f5d57ec 100644

--- a/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/VrShellNavigationTest.java

+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/VrShellNavigationTest.java

@@ -116,6 +116,9 @@ public class VrShellNavigationTest {

VrShellDelegate.getVrShellForTesting().getWebVrModeEnabled());

Assert.assertEquals("Browser is in fullscreen",

fullscreenMode == FullscreenMode.FULLSCREENED, DOMUtils.isFullscreen(wc));

+ // Feedback infobar should never show up during navigations.

+ Assert.assertFalse(VrUtils.isInfoBarPresent(

+ mActivityTestRule.getActivity().getWindow().getDecorView()));

}

public int loadUrl(String url, long secondsToWait)