Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Unified Diff: chromeos/dbus/session_manager_client.h

Issue 2887363003: Read container_instance_id. (Closed)
Patch Set: Address comments. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromeos/dbus/session_manager_client.h
diff --git a/chromeos/dbus/session_manager_client.h b/chromeos/dbus/session_manager_client.h
index e1554fbaca6dbe11f91da0922a610f5378078fed..cf7c64bc1325b57dd3f04e3fad469ebfd1198b3a 100644
--- a/chromeos/dbus/session_manager_client.h
+++ b/chromeos/dbus/session_manager_client.h
@@ -72,7 +72,10 @@ class CHROMEOS_EXPORT SessionManagerClient : public DBusClient {
// Called when the ARC instance is stopped after it had already started.
// |clean| is true if the instance was stopped as a result of an explicit
// request, false if it died unexpectedly.
- virtual void ArcInstanceStopped(bool clean) {}
+ // |container_instance_id| is the identifier of the container instance.
+ // See details for StartArcInstance().
Luis Héctor Chávez 2017/05/19 15:23:03 maybe it's better to refer to the details of Start
hidehiko 2017/05/22 08:38:06 Done.
+ virtual void ArcInstanceStopped(bool clean,
+ const std::string& container_instance_id) {}
};
// Interface for performing actions on behalf of the stub implementation.
@@ -291,7 +294,12 @@ class CHROMEOS_EXPORT SessionManagerClient : public DBusClient {
UNKNOWN_ERROR,
LOW_FREE_DISK_SPACE,
};
- using StartArcInstanceCallback = base::Callback<void(StartArcInstanceResult)>;
+ // In case of success, container_instance_id will be passed as its second
Luis Héctor Chávez 2017/05/19 15:23:03 nit: |container_instance_id|, for consistency.
hidehiko 2017/05/22 08:38:06 Done.
+ // param. The ID is passed to ArcInstanceStopped() to identify which instance
+ // is stopped.
+ using StartArcInstanceCallback =
+ base::Callback<void(StartArcInstanceResult result,
+ const std::string& container_instance_id)>;
virtual void StartArcInstance(const cryptohome::Identification& cryptohome_id,
bool disable_boot_completed_broadcast,
bool enable_vendor_privileged,

Powered by Google App Engine
This is Rietveld 408576698