Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Unified Diff: chromeos/dbus/fake_session_manager_client.cc

Issue 2887363003: Read container_instance_id. (Closed)
Patch Set: Address comments. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/chromeos/arc/arc_session_manager.cc ('k') | chromeos/dbus/session_manager_client.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromeos/dbus/fake_session_manager_client.cc
diff --git a/chromeos/dbus/fake_session_manager_client.cc b/chromeos/dbus/fake_session_manager_client.cc
index eb78cd538288d64ea9b80fddcae71d7194d03ad4..66ddb5a20a849f8c732aa5feda0d395705720379 100644
--- a/chromeos/dbus/fake_session_manager_client.cc
+++ b/chromeos/dbus/fake_session_manager_client.cc
@@ -4,12 +4,14 @@
#include "chromeos/dbus/fake_session_manager_client.h"
+#include "base/base64.h"
#include "base/bind.h"
#include "base/files/file_path.h"
#include "base/files/file_util.h"
#include "base/location.h"
#include "base/numerics/safe_conversions.h"
#include "base/path_service.h"
+#include "base/rand_util.h"
#include "base/single_thread_task_runner.h"
#include "base/strings/string_util.h"
#include "base/threading/thread_task_runner_handle.h"
@@ -243,11 +245,16 @@ void FakeSessionManagerClient::StartArcInstance(
bool disable_boot_completed_broadcast,
bool enable_vendor_privileged,
const StartArcInstanceCallback& callback) {
+ StartArcInstanceResult result;
+ std::string container_instance_id;
+ if (arc_available_) {
+ result = StartArcInstanceResult::SUCCESS;
+ base::Base64Encode(base::RandBytesAsString(16), &container_instance_id);
+ } else {
+ result = StartArcInstanceResult::UNKNOWN_ERROR;
+ }
base::ThreadTaskRunnerHandle::Get()->PostTask(
- FROM_HERE,
- base::Bind(callback, arc_available_
- ? StartArcInstanceResult::SUCCESS
- : StartArcInstanceResult::UNKNOWN_ERROR));
+ FROM_HERE, base::Bind(callback, result, container_instance_id));
}
void FakeSessionManagerClient::StopArcInstance(const ArcCallback& callback) {
« no previous file with comments | « chrome/browser/chromeos/arc/arc_session_manager.cc ('k') | chromeos/dbus/session_manager_client.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698