Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1389)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: third_party/WebKit/Source/core/css/CSSProperties.json5

Issue 2887333003: Generate StyleRareInheritedData in ComputedStyleBase. (Closed)
Patch Set: Address nits Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« third_party/WebKit/Source/build/scripts/make_computed_style_base.py ('K') | « third_party/WebKit/Source/build/scripts/templates/fields/group.tmpl ('k') | third_party/WebKit/Source/core/css/ComputedStyleExtraFields.json5 » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/css/CSSProperties.json5
diff --git a/third_party/WebKit/Source/core/css/CSSProperties.json5 b/third_party/WebKit/Source/core/css/CSSProperties.json5
index 1693efd4f9b06f9a35b6b44fadc614d453d2bfdc..233e397527d372a523759fcb7cce8df15dbcc2c7 100644
--- a/third_party/WebKit/Source/core/css/CSSProperties.json5
+++ b/third_party/WebKit/Source/core/css/CSSProperties.json5
@@ -109,6 +109,13 @@
field_type_path: {
},
+ // Name of the pointer type that wraps this field (e.g. RefPtr).
+ // Can only be set if the field template is storage_only.
+ pointer_type_name: {
+ valid_type: "str",
+ valid_values: ["RefPtr", "Persistent"],
+ },
+
// - keywords: ["keyword1", "keyword2"]
// This specifies all valid keyword values for the property.
// TODO(sashab): Once all properties are represented here, delete
@@ -513,7 +520,11 @@
custom_value: true,
inherited: true,
priority: "High",
+ field_template: "storage_only",
type_name: "TextOrientation",
+ default_value: "kTextOrientationMixed",
+ field_size: 2,
+ field_group: "rare-inherited",
},
{
name: "-webkit-text-orientation",
@@ -942,6 +953,10 @@
custom_all: true,
inherited: true,
interpolable: true,
+ field_template: "storage_only",
+ field_type_path: "platform/graphics/Color",
+ default_value: "Color()",
+ field_group: "rare-inherited",
},
{
name: "clear",
@@ -1249,11 +1264,20 @@
name: "hyphens",
inherited: true,
runtime_flag: "CSSHyphens",
+ field_template: "storage_only",
type_name: "Hyphens",
+ default_value: "Hyphens::kManual",
+ field_size: 2,
+ field_group: "rare-inherited",
},
{
name: "image-rendering",
inherited: true,
+ field_template: "storage_only",
+ type_name: "EImageRendering",
+ default_value: "kImageRenderingAuto",
+ field_size: 3,
+ field_group: "rare-inherited",
},
{
name: "image-orientation",
@@ -1339,6 +1363,10 @@
converter: "ConvertComputedLength<uint8_t>",
inherited: true,
runtime_flag: "CSSSnapSize",
+ field_template: "storage_only",
+ type_name: "uint8_t",
+ default_value: "0",
+ field_group: "rare-inherited",
},
{
name: "list-style-image",
@@ -1348,6 +1376,11 @@
inherited: true,
interpolable: true,
typedom_types: ["Image"],
+ field_template: "storage_only",
+ type_name: "StyleImage",
+ pointer_type_name: "Persistent",
+ default_value: "nullptr",
+ field_group: "rare-inherited",
},
{
name: "list-style-position",
@@ -1561,6 +1594,9 @@
inherited: true,
interpolable: true,
type_name: "short",
+ field_template: "storage_only",
+ default_value: "2",
+ field_group: "rare-inherited",
},
{
name: "outline-color",
@@ -1600,6 +1636,11 @@
{
name: "overflow-wrap",
inherited: true,
+ field_template: "storage_only",
+ type_name: "EOverflowWrap",
+ default_value: "EOverflowWrap::kNormal",
+ field_size: 1,
+ field_group: "rare-inherited",
},
{
name: "overflow-x",
@@ -1708,6 +1749,11 @@
api_methods: ["parseSingleValue"],
converter: "ConvertQuotes",
inherited: true,
+ field_template: "storage_only",
+ field_type_path: "core/style/QuotesData",
+ default_value: "nullptr",
+ pointer_type_name: "RefPtr",
+ field_group: "rare-inherited",
},
{
name: "resize",
@@ -1818,6 +1864,11 @@
{
name: "speak",
inherited: true,
+ field_template: "storage_only",
+ type_name: "ESpeak",
+ default_value: "ESpeak::kNormal",
+ field_size: 3,
+ field_group: "rare-inherited",
},
{
name: "stop-color",
@@ -1919,7 +1970,11 @@
api_methods: ["parseSingleValue"],
converter: "ConvertLengthOrTabSpaces",
inherited: true,
- type_name: "TabSize",
+ getter: "GetTabSize",
+ field_type_path: "platform/text/TabSize",
+ field_template: "storage_only",
+ default_value: "TabSize(8)",
+ field_group: "rare-inherited",
},
{
name: "text-align",
@@ -1936,7 +1991,11 @@
{
name: "text-align-last",
inherited: true,
+ field_template: "storage_only",
type_name: "TextAlignLast",
+ default_value: "kTextAlignLastAuto",
+ field_size: 3,
+ field_group: "rare-inherited",
},
{
name: "text-anchor",
@@ -1947,7 +2006,11 @@
name: "text-combine-upright",
inherited: true,
name_for_methods: "TextCombine",
+ field_template: "storage_only",
type_name: "TextCombine",
+ default_value: "kTextCombineNone",
+ field_size: 1,
+ field_group: "rare-inherited",
},
// FIXME: We shouldn't switch between shorthand/not shorthand based on a runtime flag
{
@@ -1979,7 +2042,11 @@
converter: "ConvertFlags<TextDecorationSkip>",
inherited: true,
runtime_flag: "CSS3TextDecorations",
+ field_template: "storage_only",
type_name: "TextDecorationSkip",
+ default_value: "kTextDecorationSkipObjects",
+ field_size: 3,
+ field_group: "rare-inherited",
},
{
name: "text-decoration-style",
@@ -1993,12 +2060,22 @@
custom_all: true,
inherited: true,
interpolable: true,
+ field_template: "storage_only",
+ field_type_path: "platform/Length",
+ default_value: "Length(kFixed)",
+ field_group: "rare-inherited",
},
{
name: "text-justify",
inherited: true,
runtime_flag: "CSS3Text",
+ getter: "GetTextJustify",
+ field_template: "storage_only",
+ field_type_path: "platform/text/TextJustify",
type_name: "TextJustify",
+ default_value: "kTextJustifyAuto",
+ field_size: 2,
+ field_group: "rare-inherited",
},
{
name: "text-overflow",
@@ -2009,6 +2086,11 @@
converter: "ConvertShadowList",
inherited: true,
interpolable: true,
+ field_template: "storage_only",
+ field_type_path: "core/style/ShadowList",
+ pointer_type_name: "RefPtr",
+ default_value: "nullptr",
+ field_group: "rare-inherited",
},
{
name: "text-size-adjust",
@@ -2016,7 +2098,11 @@
api_methods: ["parseSingleValue"],
converter: "ConvertTextSizeAdjust",
inherited: true,
- type_name: "TextSizeAdjust",
+ getter: "GetTextSizeAdjust",
+ field_template: "storage_only",
+ field_type_path: "core/style/TextSizeAdjust",
+ default_value: "TextSizeAdjust::AdjustAuto()",
+ field_group: "rare-inherited",
},
{
name: "text-transform",
@@ -2032,7 +2118,11 @@
api_methods: ["parseSingleValue"],
inherited: true,
runtime_flag: "CSS3TextDecorations",
+ field_template: "storage_only",
type_name: "TextUnderlinePosition",
+ default_value: "kTextUnderlinePositionAuto",
+ field_size: 1,
+ field_group: "rare-inherited",
},
{
name: "top",
@@ -2297,17 +2387,29 @@
api_methods: ["parseSingleValue"],
converter: "ConvertString<CSSValueNone>",
inherited: true,
+ field_template: "storage_only",
+ field_type_path: "platform/wtf/text/AtomicString",
+ default_value: "g_null_atom",
+ field_group: "rare-inherited",
},
{
name: "-webkit-hyphenate-character",
converter: "ConvertString<CSSValueAuto>",
inherited: true,
name_for_methods: "HyphenationString",
+ field_template: "storage_only",
+ field_type_path: "platform/wtf/text/AtomicString",
+ default_value: "AtomicString()",
+ field_group: "rare-inherited",
},
{
name: "-webkit-line-break",
inherited: true,
+ field_template: "storage_only",
type_name: "LineBreak",
+ default_value: "LineBreak::kAuto",
+ field_size: 3,
+ field_group: "rare-inherited",
},
{
name: "-webkit-line-clamp",
@@ -2439,7 +2541,11 @@
{
name: "-webkit-ruby-position",
inherited: true,
+ field_template: "storage_only",
type_name: "RubyPosition",
+ default_value: "kRubyPositionBefore",
+ field_size: 1,
+ field_group: "rare-inherited",
},
{
name: "-webkit-tap-highlight-color",
@@ -2447,6 +2553,10 @@
api_methods: ["parseSingleValue"],
converter: "ConvertColor",
inherited: true,
+ field_template: "storage_only",
+ field_type_path: "platform/graphics/Color",
+ default_value: "LayoutTheme::TapHighlightColor()",
+ field_group: "rare-inherited",
},
{
name: "-webkit-text-combine",
@@ -2460,6 +2570,10 @@
api_methods: ["parseSingleValue"],
custom_all: true,
inherited: true,
+ field_template: "storage_only",
+ field_type_path: "platform/graphics/Color",
+ default_value: "Color()",
+ field_group: "rare-inherited",
},
{
name: "-webkit-text-emphasis-position",
@@ -2479,10 +2593,19 @@
api_methods: ["parseSingleValue"],
custom_all: true,
inherited: true,
+ field_template: "storage_only",
+ field_type_path: "platform/graphics/Color",
+ default_value: "Color()",
+ field_group: "rare-inherited",
},
{
name: "-webkit-text-security",
inherited: true,
+ field_template: "storage_only",
+ type_name: "ETextSecurity",
+ default_value: "ETextSecurity::kNone",
+ field_size: 2,
+ field_group: "rare-inherited",
},
{
name: "-webkit-text-stroke-color",
@@ -2491,6 +2614,10 @@
custom_all: true,
inherited: true,
interpolable: true,
+ field_template: "storage_only",
+ field_type_path: "platform/graphics/Color",
+ default_value: "Color()",
+ field_group: "rare-inherited",
},
{
name: "-webkit-text-stroke-width",
@@ -2498,6 +2625,10 @@
api_methods: ["parseSingleValue"],
converter: "ConvertTextStrokeWidth",
inherited: true,
+ field_template: "storage_only",
+ type_name: "float",
+ default_value: "0",
+ field_group: "rare-inherited",
},
{
name: "-webkit-transform-origin-x",
@@ -2522,10 +2653,20 @@
{
name: "-webkit-user-modify",
inherited: true,
+ field_template: "storage_only",
+ type_name: "EUserModify",
+ default_value: "EUserModify::kReadOnly",
+ field_size: 2,
+ field_group: "rare-inherited",
},
{
name: "user-select",
inherited: true,
+ field_template: "storage_only",
+ type_name: "EUserSelect",
+ default_value: "true",
+ field_size: 2,
+ field_group: "rare-inherited",
},
{
name: "white-space",
@@ -2541,7 +2682,10 @@
api_methods: ["parseSingleValue"],
inherited: true,
interpolable: true,
+ field_template: "storage_only",
type_name: "short",
+ default_value: "2",
+ field_group: "rare-inherited",
},
{
name: "width",
@@ -2566,6 +2710,11 @@
{
name: "word-break",
inherited: true,
+ field_template: "storage_only",
+ type_name: "EWordBreak",
+ default_value: "EWordBreak::kNormal",
+ field_size: 2,
+ field_group: "rare-inherited",
},
{
name: "word-spacing",
« third_party/WebKit/Source/build/scripts/make_computed_style_base.py ('K') | « third_party/WebKit/Source/build/scripts/templates/fields/group.tmpl ('k') | third_party/WebKit/Source/core/css/ComputedStyleExtraFields.json5 » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698