Issue 288733002: Kill WTF::GregorianDateTime class

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 288733002: Kill WTF::GregorianDateTime class (Closed)

Created:
6 years, 7 months ago by Inactive

Modified:
6 years, 7 months ago

Reviewers:
abarth-chromium, eseidel

CC:
blink-reviews, blink-reviews-wtf_chromium.org, Mikhail, abarth-chromium

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

Kill WTF::GregorianDateTime class Kill WTF::GregorianDateTime class and use DateComponents from platform/ instead. There is little sense in having 2 different classes to do the same thing. This makes the code a bit more consistent and also reduces the binary size slightly. R=eseidel@chromium.org, abarth@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174069

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+10 lines, -221 lines)			Patch
M	Source/platform/DateComponents.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/platform/DateComponents.cpp	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	Source/platform/mhtml/MHTMLArchive.cpp	View	3 chunks	+4 lines, -4 lines	0 comments	Download
D	Source/wtf/GregorianDateTime.h	View	1 chunk	+0 lines, -129 lines	0 comments	Download
D	Source/wtf/GregorianDateTime.cpp	View	1 chunk	+0 lines, -86 lines	0 comments	Download
M	Source/wtf/wtf.gypi	View	1 chunk	+0 lines, -2 lines	0 comments	Download

Total messages: 4 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/288733002/1

6 years, 7 months ago (2014-05-15 06:27:20 UTC) #3

Message was sent while issue was closed.

Change committed as 174069