Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(779)

Unified Diff: third_party/WebKit/Source/devtools/front_end/audits2/lighthouse/renderer/dom.js

Issue 2887313002: Revert of DevTools: Roll Lighthouse binary to 2.0.0-alpha.7 (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/audits2/lighthouse/renderer/dom.js
diff --git a/third_party/WebKit/Source/devtools/front_end/audits2/lighthouse/renderer/dom.js b/third_party/WebKit/Source/devtools/front_end/audits2/lighthouse/renderer/dom.js
index 83ab5fdae12c7927a2e2c3639b194a2dd728b29e..28e02dac9ffc9da49f2bb8776f0055fee1dc6f18 100644
--- a/third_party/WebKit/Source/devtools/front_end/audits2/lighthouse/renderer/dom.js
+++ b/third_party/WebKit/Source/devtools/front_end/audits2/lighthouse/renderer/dom.js
@@ -101,7 +101,7 @@
* @param {string} text
* @return {!Element}
*/
- convertMarkdownLinkSnippets(text) {
+ createSpanFromMarkdown(text) {
const element = this.createElement('span');
// Split on markdown links (e.g. [some link](https://...)).
@@ -120,28 +120,6 @@
a.textContent = linkText;
a.href = (new URL(linkHref)).href;
element.appendChild(a);
- }
- }
-
- return element;
- }
-
- /**
- * @param {string} text
- * @return {!Element}
- */
- convertMarkdownCodeSnippets(text) {
- const element = this.createElement('span');
-
- const parts = text.split(/`(.*?)`/g); // Split on markdown code slashes
- while (parts.length) {
- // Pop off the same number of elements as there are capture groups.
- const [preambleText, codeText] = parts.splice(0, 2);
- element.appendChild(this._document.createTextNode(preambleText));
- if (codeText) {
- const pre = /** @type {!HTMLPreElement} */ (this.createElement('code'));
- pre.textContent = codeText;
- element.appendChild(pre);
}
}

Powered by Google App Engine
This is Rietveld 408576698