third_party/WebKit/Source/core/editing/FrameCaret.cpp - Issue 2887303002: Blink caret only if selection has focus.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/FrameCaret.cpp

Issue 2887303002: Blink caret only if selection has focus. (Closed)

Patch Set: update Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/editing/FrameCaret.cpp

diff --git a/third_party/WebKit/Source/core/editing/FrameCaret.cpp b/third_party/WebKit/Source/core/editing/FrameCaret.cpp

index 8a63733d2cef973bdf7a5bf23060356bc7f45792..d41368759f3f54c323264ed63a8d62099c1bcf39 100644

--- a/third_party/WebKit/Source/core/editing/FrameCaret.cpp

+++ b/third_party/WebKit/Source/core/editing/FrameCaret.cpp

@@ -28,6 +28,7 @@

#include "core/dom/TaskRunnerHelper.h"

#include "core/editing/CaretDisplayItemClient.h"

#include "core/editing/EditingUtilities.h"

+#include "core/editing/FrameSelection.h"

#include "core/editing/SelectionEditor.h"

#include "core/frame/FrameView.h"

#include "core/frame/LocalFrame.h"

@@ -212,8 +213,7 @@ bool FrameCaret::ShouldBlinkCaret() const {

if (!focused_element)

return false;

- return focused_element->IsShadowIncludingInclusiveAncestorOf(

- CaretPosition().AnchorNode());

+ return frame_->Selection().SelectionHasFocus();

}

void FrameCaret::CaretBlinkTimerFired(TimerBase*) {