Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: extensions/browser/extension_event_histogram_value.h

Issue 2887293003: Modernize some extensions code. (Closed)
Patch Set: address comments Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « extensions/browser/event_router_unittest.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef EXTENSIONS_BROWSER_EXTENSION_EVENT_HISTOGRAM_VALUE_H_ 5 #ifndef EXTENSIONS_BROWSER_EXTENSION_EVENT_HISTOGRAM_VALUE_H_
6 #define EXTENSIONS_BROWSER_EXTENSION_EVENT_HISTOGRAM_VALUE_H_ 6 #define EXTENSIONS_BROWSER_EXTENSION_EVENT_HISTOGRAM_VALUE_H_
7 7
8 namespace extensions { 8 namespace extensions {
9 namespace events { 9 namespace events {
10 10
11 // TODO(kalman): I am still in the process of migrating Event construction away
12 // from using "UNKNOWN" to their real histogram values. See crbug.com/503402.
13 //
14 // Short version: 11 // Short version:
15 // *Never* reorder or delete entries in the |HistogramValue| enumeration. 12 // *Never* reorder or delete entries in the |HistogramValue| enumeration.
16 // When creating a new extension event, add a new entry at the end of the 13 // When creating a new extension event, add a new entry at the end of the
17 // enum, just prior to ENUM_BOUNDARY. 14 // enum, just prior to ENUM_BOUNDARY.
18 // 15 //
19 // Long version: See extension_function_histogram_value.h 16 // Long version: See extension_function_histogram_value.h
20 enum HistogramValue { 17 enum HistogramValue {
21 UNKNOWN = 0, 18 UNKNOWN = 0,
22 FOR_TEST, // Tests should use this for a stub histogram value (not UNKNOWN). 19 FOR_TEST, // Tests should use this for a stub histogram value (not UNKNOWN).
23 ACCESSIBILITY_PRIVATE_ON_INTRODUCE_CHROME_VOX, 20 ACCESSIBILITY_PRIVATE_ON_INTRODUCE_CHROME_VOX,
(...skipping 404 matching lines...) Expand 10 before | Expand all | Expand 10 after
428 ACCESSIBILITY_PRIVATE_ON_TWO_FINGER_TOUCH_STOP, 425 ACCESSIBILITY_PRIVATE_ON_TWO_FINGER_TOUCH_STOP,
429 // Last entry: Add new entries above, then run: 426 // Last entry: Add new entries above, then run:
430 // python tools/metrics/histograms/update_extension_histograms.py 427 // python tools/metrics/histograms/update_extension_histograms.py
431 ENUM_BOUNDARY 428 ENUM_BOUNDARY
432 }; 429 };
433 430
434 } // namespace events 431 } // namespace events
435 } // namespace extensions 432 } // namespace extensions
436 433
437 #endif // EXTENSIONS_BROWSER_EXTENSION_EVENT_HISTOGRAM_VALUE_H_ 434 #endif // EXTENSIONS_BROWSER_EXTENSION_EVENT_HISTOGRAM_VALUE_H_
OLDNEW
« no previous file with comments | « extensions/browser/event_router_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698