base/win/scoped_comptr_unittest.cc - Issue 2887243002: Remove ScopedComPtr::CreateInstance()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/win/scoped_comptr_unittest.cc

Issue 2887243002: Remove ScopedComPtr::CreateInstance() (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/win/scoped_comptr_unittest.cc

diff --git a/base/win/scoped_comptr_unittest.cc b/base/win/scoped_comptr_unittest.cc

index 2493433ab0b96b6f8a6c9905ce4c4d6f74140cb4..edfa8cfc6fafb63299afab33e5f4c1c1982a62cf 100644

--- a/base/win/scoped_comptr_unittest.cc

+++ b/base/win/scoped_comptr_unittest.cc

@@ -39,7 +39,8 @@ TEST(ScopedComPtrTest, ScopedComPtr) {

EXPECT_TRUE(com_initializer.succeeded());

ScopedComPtr<IUnknown> unk;

- EXPECT_TRUE(SUCCEEDED(unk.CreateInstance(CLSID_ShellLink)));

+ EXPECT_TRUE(SUCCEEDED(::CoCreateInstance(CLSID_ShellLink, nullptr, CLSCTX_ALL,

+ IID_PPV_ARGS(&unk))));

ScopedComPtr<IUnknown> unk2;

unk2.Attach(unk.Detach());

EXPECT_TRUE(unk.Get() == NULL);

« no previous file with comments | « base/win/scoped_comptr.h ('k') | base/win/shortcut.cc » ('j') | no next file with comments »