Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Unified Diff: src/isolate.cc

Issue 2887193002: Create a thread safe version of StatsCounters and use. (Closed)
Patch Set: Clean up nits. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« src/counters.h ('K') | « src/isolate.h ('k') | src/wasm/wasm-module.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/isolate.cc
diff --git a/src/isolate.cc b/src/isolate.cc
index cd4d077198d8ade2b7e46f8cda4dc7daaadaf5c0..0b63db0a2c4992b70feafeae99718c3ded9d8ab5 100644
--- a/src/isolate.cc
+++ b/src/isolate.cc
@@ -2562,7 +2562,6 @@ Isolate::~Isolate() {
delete logger_;
logger_ = NULL;
- delete counters_;
counters_ = NULL;
delete handle_scope_implementer_;
@@ -2648,14 +2647,22 @@ bool Isolate::PropagatePendingExceptionToExternalTryCatch() {
return true;
}
+static base::LazyMutex initialize_counters_mutex = LAZY_MUTEX_INITIALIZER;
+
+bool Isolate::InitializeCounters() {
+ if (counters_ != NULL) return false;
+ base::LockGuard<base::Mutex> guard(initialize_counters_mutex.Pointer());
+ if (counters_ != NULL) return false;
+ counters_shared_ = std::make_shared<Counters>(this);
+ counters_ = counters_shared_.get();
+ return true;
+}
void Isolate::InitializeLoggingAndCounters() {
if (logger_ == NULL) {
logger_ = new Logger(this);
}
- if (counters_ == NULL) {
- counters_ = new Counters(this);
- }
+ InitializeCounters();
}
« src/counters.h ('K') | « src/isolate.h ('k') | src/wasm/wasm-module.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698