Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1362)

Unified Diff: remoting/protocol/webrtc_video_renderer_adapter.cc

Issue 2887183004: Ensure that remoting_unittests fail when playout delay > 0. (Closed)
Patch Set: fix failure on windows Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/protocol/connection_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/protocol/webrtc_video_renderer_adapter.cc
diff --git a/remoting/protocol/webrtc_video_renderer_adapter.cc b/remoting/protocol/webrtc_video_renderer_adapter.cc
index 8e660333cdcd050f628321f01398fd297d0f8c94..202ed9bb3ebb2ccc416d3aedf85158fcf7b66580 100644
--- a/remoting/protocol/webrtc_video_renderer_adapter.cc
+++ b/remoting/protocol/webrtc_video_renderer_adapter.cc
@@ -95,10 +95,10 @@ void WebrtcVideoRendererAdapter::SetVideoStatsChannel(
}
void WebrtcVideoRendererAdapter::OnFrame(const webrtc::VideoFrame& frame) {
- if (frame.timestamp_us() >= rtc::TimeMicros()) {
+ if (frame.timestamp_us() > rtc::TimeMicros()) {
// The host sets playout delay to 0, so all incoming frames are expected to
// be rendered as so as they are received.
- LOG(WARNING) << "Received frame with playout delay greater than 0.";
+ NOTREACHED() << "Received frame with playout delay greater than 0.";
}
task_runner_->PostTask(
« no previous file with comments | « remoting/protocol/connection_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698