Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Unified Diff: third_party/WebKit/Source/core/layout/compositing/CompositingInputsUpdater.cpp

Issue 2887173002: Fix DCHECK to account for child SVG objects not having PaintLayers. (Closed)
Patch Set: Merge branch 'master' into foreignobjectcrash Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/svg/clip-path/clip-path-foreign-object-crash.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/layout/compositing/CompositingInputsUpdater.cpp
diff --git a/third_party/WebKit/Source/core/layout/compositing/CompositingInputsUpdater.cpp b/third_party/WebKit/Source/core/layout/compositing/CompositingInputsUpdater.cpp
index c8f3f1db5a3cff773419d8e7fc1d10631c5cee93..5c613db689626b254e520fedd5af301006d512b6 100644
--- a/third_party/WebKit/Source/core/layout/compositing/CompositingInputsUpdater.cpp
+++ b/third_party/WebKit/Source/core/layout/compositing/CompositingInputsUpdater.cpp
@@ -52,7 +52,8 @@ static const PaintLayer* FindParentLayerOnClippingContainerChain(
// SVG (other than LayoutSVGRoot) cannot have PaintLayers.
DCHECK(!current->HasClipRelatedProperty() ||
current->StyleRef().ContainsPaint() ||
- (current->IsBox() && ToLayoutBox(current)->HasControlClip()));
+ (current->IsBox() && ToLayoutBox(current)->HasControlClip()) ||
+ current->IsSVGChild());
}
NOTREACHED();
return nullptr;
« no previous file with comments | « third_party/WebKit/LayoutTests/svg/clip-path/clip-path-foreign-object-crash.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698